Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(140)

Issue 319360043: [plaso] Added experimenal SQLite storage file (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 months, 1 week ago by Joachim Metz
Modified:
5 months ago
Reviewers:
onager
CC:
kiddi, log2timeline-dev_googlegroups.com, jberggren, romaing
Visibility:
Public.

Description

[plaso] Added experimenal SQLite storage file

Patch Set 1 #

Total comments: 44

Patch Set 2 : Changes after review #

Total comments: 14

Patch Set 3 : Changes after review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1230 lines, -529 lines) Patch
M plaso/frontend/extraction_frontend.py View 1 2 3 chunks +7 lines, -0 lines 0 comments Download
M plaso/multi_processing/task_engine.py View 1 2 3 chunks +11 lines, -10 lines 0 comments Download
M plaso/multi_processing/task_manager.py View 6 chunks +6 lines, -8 lines 0 comments Download
M plaso/storage/gzip_file.py View 1 chunk +1 line, -1 line 0 comments Download
M plaso/storage/identifiers.py View 1 2 2 chunks +34 lines, -1 line 0 comments Download
M plaso/storage/interface.py View 1 6 chunks +549 lines, -0 lines 0 comments Download
A plaso/storage/sqlite_file.py View 1 2 1 chunk +546 lines, -0 lines 0 comments Download
M plaso/storage/zip_file.py View 1 7 chunks +25 lines, -476 lines 0 comments Download
M tests/storage/gzip_file.py View 1 chunk +1 line, -1 line 0 comments Download
A + tests/storage/sqlite_file.py View 16 chunks +49 lines, -31 lines 0 comments Download
M tests/storage/zip_file.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9
Joachim Metz
8 months, 1 week ago (2017-02-13 06:52:16 UTC) #1
onager
https://codereview.appspot.com/319360043/diff/1/plaso/multi_processing/task_engine.py File plaso/multi_processing/task_engine.py (right): https://codereview.appspot.com/319360043/diff/1/plaso/multi_processing/task_engine.py#newcode438 plaso/multi_processing/task_engine.py:438: task_name = u'{0:s} task queue'.format(process_name) rename to queue_name = ...
6 months, 4 weeks ago (2017-03-29 12:52:03 UTC) #2
Joachim Metz
https://codereview.appspot.com/319360043/diff/1/plaso/multi_processing/task_engine.py File plaso/multi_processing/task_engine.py (right): https://codereview.appspot.com/319360043/diff/1/plaso/multi_processing/task_engine.py#newcode438 plaso/multi_processing/task_engine.py:438: task_name = u'{0:s} task queue'.format(process_name) On 2017/03/29 12:52:02, onager ...
6 months, 2 weeks ago (2017-04-08 18:11:31 UTC) #3
Joachim Metz
Code updated.
6 months, 2 weeks ago (2017-04-08 18:14:01 UTC) #4
onager
https://codereview.appspot.com/319360043/diff/20001/plaso/storage/identifiers.py File plaso/storage/identifiers.py (right): https://codereview.appspot.com/319360043/diff/20001/plaso/storage/identifiers.py#newcode42 plaso/storage/identifiers.py:42: """The SQL table attribute container identifier. -The https://codereview.appspot.com/319360043/diff/20001/plaso/storage/sqlite_file.py File ...
5 months, 1 week ago (2017-05-19 09:00:46 UTC) #5
Joachim Metz
https://codereview.appspot.com/319360043/diff/20001/plaso/storage/identifiers.py File plaso/storage/identifiers.py (right): https://codereview.appspot.com/319360043/diff/20001/plaso/storage/identifiers.py#newcode42 plaso/storage/identifiers.py:42: """The SQL table attribute container identifier. On 2017/05/19 09:00:45, ...
5 months, 1 week ago (2017-05-19 11:13:43 UTC) #6
Joachim Metz
Code updated.
5 months ago (2017-05-20 05:26:03 UTC) #7
onager
LGTM
5 months ago (2017-05-25 18:41:58 UTC) #8
Joachim Metz
5 months ago (2017-05-26 04:15:55 UTC) #9
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close storage1
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted