Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3144)

Issue 31930043: Add animations to browser (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 5 months ago by huwshimi
Modified:
10 years, 5 months ago
Reviewers:
mp+196475, jeff.pihach
Visibility:
Public.

Description

Add animations to browser I had a bit of a realisation about how we could do open animations for the browser panels. It seems to QA accross browsers and even though the panels don't animate on close I think it's worth having. I'm hoping this might be enough that we don't have to worry about animations on close... There is one point which might be considered a bug in that the panels will animate in on page load instead of remaining in the open state. I think this is an OK trade off, but others may feel differently. https://code.launchpad.net/~huwshimi/juju-gui/more-animations/+merge/196475 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -1 line) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M lib/views/browser/browser-icon.less View 2 chunks +65 lines, -1 line 0 comments Download
M lib/views/browser/main.less View 3 chunks +38 lines, -0 lines 0 comments Download

Messages

Total messages: 3
huwshimi
Please take a look.
10 years, 5 months ago (2013-11-25 07:02:43 UTC) #1
jeff.pihach
LGTM QA OK I think this is great good work! The animation in on page ...
10 years, 5 months ago (2013-11-25 14:24:01 UTC) #2
jeff.pihach
10 years, 5 months ago (2013-11-25 14:36:14 UTC) #3
*** Submitted:

Add animations to browser

I had a bit of a realisation about how we could do open animations for the
browser panels. It seems to QA accross browsers and even though the panels don't
animate on close I think it's worth having.

I'm hoping this might be enough that we don't have to worry about animations on
close...

There is one point which might be considered a bug in that the panels will
animate in on page load instead of remaining in the open state. I think this is
an OK trade off, but others may feel differently.

R=jeff.pihach
CC=
https://codereview.appspot.com/31930043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b