Issue 319100043: TBR: i#2124: work around clang bug via local var

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 319100043: TBR: i#2124: work around clang bug via local var

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 3 months ago by bruening

Modified:
7 years, 3 months ago

Reviewers:
zhaoqin

CC:
dynamorio-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- i#2124: work around clang bug via local var Works around a clang bug that incorrectly elides a compare, causing an assert to fire, by routing a constant through a local variable. Fixes #2124 ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -5 lines)			Patch
	M	core/arch/arch_exports.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	core/native_exec.c	View		2 chunks	+7 lines, -3 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bruening

7 years, 3 months ago (2017-01-18 04:56:59 UTC) #2

Committed as
https://github.com/DynamoRIO/dynamorio/commit/fd9cbbb621bbe3bfbcd02f456fc2685...

Final commit log: 
---------------
i#2124: work around clang bug via local var

Works around a clang bug that incorrectly elides a compare, causing an
assert to fire, by routing a constant through a local variable.

Fixes #2124

Review-URL: https://codereview.appspot.com/319100043
---------------

Expand All Messages | Collapse All Messages