Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3943)

Issue 319080043: TBR: i#2122: fix out-of-bounds reads in os_page_size_init()

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 3 months ago by bruening
Modified:
7 years, 3 months ago
Reviewers:
zhaoqin
CC:
dynamorio-devs_googlegroups.com
Visibility:
Public.

Description

Commit log for first patchset: --------------- i#2122: fix out-of-bounds reads in os_page_size_init() Disables the beyond-environ reads in os_page_size_init() for STATIC_LIBRARY where they are likely to not be on the stack and instead read off into unallocated memory. Fixes #2122 ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M core/unix/os.c View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 2
bruening
7 years, 3 months ago (2017-01-06 02:41:35 UTC) #1
bruening
7 years, 3 months ago (2017-01-06 02:41:36 UTC) #2
Committed as
https://github.com/DynamoRIO/dynamorio/commit/3360fee852accd08ebb9ba08813cb33...

Final commit log: 
---------------
i#2122: fix out-of-bounds reads in os_page_size_init()

Disables the beyond-environ reads in os_page_size_init() for STATIC_LIBRARY
where they are likely to not be on the stack and instead read off into
unallocated memory.

Fixes #2122

Review-URL: https://codereview.appspot.com/319080043
---------------
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b