Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2843)

Issue 3190041: setName() on {client,server}Thread for slightly easier debugging

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 5 months ago by sgk1
Modified:
13 years, 3 months ago
Reviewers:
kenton
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M java/Test.java View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2
sgk1
This came in handy when I was adding prints to the Java execution to try ...
13 years, 5 months ago (2010-11-18 00:47:54 UTC) #1
kenton
13 years, 3 months ago (2011-01-23 22:37:46 UTC) #2
LGTM, submitted

On Wed, Nov 17, 2010 at 4:47 PM, <sgk@google.com> wrote:

> Reviewers: kenton,
>
> Message:
> This came in handy when I was adding prints to the Java execution to try
> to make sure the Python implementation was behaving similarly.  No big
> deal if you'd rather not clutter the code.
>
>
>
> Please review this at http://codereview.appspot.com/3190041/
>
> Affected files:
>  M java/Test.java
>
>
> Index: java/Test.java
> ===================================================================
> --- a/java/Test.java
> +++ b/java/Test.java
> @@ -180,6 +180,7 @@
>     ServerSocket listener =
>         new ServerSocket(port, -1, loopback);
>     Thread serverThread = new Thread(new ServerThread(listener));
> +    serverThread.setName("serverThread");
>     serverThread.start();
>
>     Socket socket = new Socket(loopback, port);
> @@ -187,6 +188,7 @@
>     TestService testService =
>         TestService.fromChannel(connection.getDefaultService());
>     Thread clientThread = new Thread(new ClientThread(connection));
> +    clientThread.setName("clientThread");
>     clientThread.start();
>
>     doHelloTest(testService);
>
>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b