Issue 319000043: TBR: i#2113: avoid racy crashes in ELF header queries

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 319000043: TBR: i#2113: avoid racy crashes in ELF header queries

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 4 months ago by bruening

Modified:
7 years, 4 months ago

Reviewers:
zhaoqin

CC:
dynamorio-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- i#2113: avoid racy crashes in ELF header queries Changes is_elf_so_header_common() to always use a safe_read() once the fast version is available during init. This avoids crashes due to protection changing in a racy manner. Fixes #2113 ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -2 lines)			Patch
M	core/unix/module_elf.c	View	2 chunks	+13 lines, -2 lines	0 comments	Download
M	core/unix/os.c	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	core/unix/os_private.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bruening

7 years, 4 months ago (2016-12-20 17:12:36 UTC) #2

Committed as
https://github.com/DynamoRIO/dynamorio/commit/71427ac79d93bda1621d076994cb4b6...

Final commit log: 
---------------
i#2113: avoid racy crashes in ELF header queries

Changes is_elf_so_header_common() to always use a safe_read() once the fast
version is available during init.  This avoids crashes due to protection
changing in a racy manner.

Fixes #2113

Review-URL: https://codereview.appspot.com/319000043
---------------

Expand All Messages | Collapse All Messages