remove callId, not serviceId, from pendingCalls

Implementing capnproto in Python turned up this seeming bug in the Java implementation.  We're adding DoneCallback instances to pendingCalls by callId, but after we receive the response we remove the entry corresponding to the serviceId.

[kenton, 2011-01-23 22:37:31]

LGTM, submitted

On Wed, Nov 17, 2010 at 4:44 PM, <sgk@google.com> wrote:

> Reviewers: kenton,
>
> Description:
> Implementing capnproto in Python turned up this seeming bug in the Java
> implementation.  We're adding DoneCallback instances to pendingCalls by
> callId, but after we receive the response we remove the entry
> corresponding to the serviceId.
>
> Please review this at http://codereview.appspot.com/3189041/
>
> Affected files:
>  M java/Connection.java
>
>
> Index: java/Connection.java
> ===================================================================
> --- a/java/Connection.java
> +++ b/java/Connection.java
> @@ -475,7 +475,7 @@
>         }
>       } finally {
>         synchronized (pendingCalls) {
> -          pendingCalls.remove(serviceId);
> +          pendingCalls.remove(callId);
>         }
>       }
>
>
>
>