Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(294)

Issue 318890043: unfoldRepeats can be restricted to certain repeat-types (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 6 months ago by thomasmorley651
Modified:
2 years, 5 months ago
Reviewers:
dak, simon.albrecht
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

unfoldRepeats can be restricted to certain repeat-types It now takes an additional, optional argument. It's a list of symbols representing the repeat-types which should be unfolded. Possible settings are percent-repeated-music, tremolo-repeated-music, volta-repeated-music and of course repeated-music which is the default and will unfold all. A new regtest is added to cover the new feature. Changes is extended accordingly. Also correcting two small typos in Documentation/notation/staff.itely

Patch Set 1 #

Patch Set 2 : Improve user-interface #

Patch Set 3 : Use hash-table, fix articulate.ly #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -22 lines) Patch
M Documentation/changes.tely View 1 1 chunk +8 lines, -0 lines 0 comments Download
M Documentation/notation/staff.itely View 1 chunk +2 lines, -2 lines 0 comments Download
A input/regression/repeat-unfold-partial.ly View 1 1 chunk +37 lines, -0 lines 0 comments Download
M ly/articulate.ly View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M ly/music-functions-init.ly View 1 1 chunk +9 lines, -4 lines 0 comments Download
M scm/music-functions.scm View 1 2 2 chunks +31 lines, -14 lines 0 comments Download

Messages

Total messages: 14
thomasmorley651
Please review
2 years, 6 months ago (2016-12-01 22:02:19 UTC) #1
simon.albrecht
Hi Harm, thanks for the patch. As for the user-interface, I’d prefer something like \unfoldRepeats ...
2 years, 6 months ago (2016-12-01 22:42:38 UTC) #2
dak
Simon Albrecht <simon.albrecht@mail.de> writes: > Hi Harm, > > thanks for the patch. > > ...
2 years, 6 months ago (2016-12-02 19:45:02 UTC) #3
thomasmorley651
Improve user-interface
2 years, 6 months ago (2016-12-03 11:13:26 UTC) #4
thomasmorley651
On 2016/12/01 22:42:38, simon.albrecht wrote: > Hi Harm, > > thanks for the patch. > ...
2 years, 6 months ago (2016-12-03 11:21:34 UTC) #5
thomasmorley651
On 2016/12/02 19:45:02, dak wrote: > However, people might get surprised by > > #(unfoldRepeats ...
2 years, 6 months ago (2016-12-03 11:26:54 UTC) #6
dak
thomasmorley65@gmail.com writes: > On 2016/12/02 19:45:02, dak wrote: >> However, people might get surprised by ...
2 years, 6 months ago (2016-12-03 11:28:24 UTC) #7
thomasmorley651
On 2016/12/03 11:28:24, dak wrote: > mailto:thomasmorley65@gmail.com writes: > > > On 2016/12/02 19:45:02, dak ...
2 years, 6 months ago (2016-12-03 11:30:41 UTC) #8
dak
David Kastrup <dak@gnu.org> writes: > As a user interface, that sounds very much desirable. I ...
2 years, 6 months ago (2016-12-03 11:33:15 UTC) #9
dak
thomasmorley65@gmail.com writes: > On 2016/12/03 11:28:24, dak wrote: >> mailto:thomasmorley65@gmail.com writes: > >> > On ...
2 years, 6 months ago (2016-12-03 11:34:48 UTC) #10
thomasmorley651
On 2016/12/03 11:33:15, dak wrote: > David Kastrup <mailto:dak@gnu.org> writes: > > > As a ...
2 years, 6 months ago (2016-12-03 11:42:14 UTC) #11
thomasmorley651
On 2016/12/03 11:34:48, dak wrote: > mailto:thomasmorley65@gmail.com writes: > > > On 2016/12/03 11:28:24, dak ...
2 years, 6 months ago (2016-12-03 11:44:01 UTC) #12
thomasmorley651
Use hash-table, fix articulate.ly
2 years, 6 months ago (2016-12-04 11:42:39 UTC) #13
thomasmorley651
2 years, 6 months ago (2016-12-04 11:46:58 UTC) #14
On 2016/12/03 11:33:15, dak wrote:
> David Kastrup <mailto:dak@gnu.org> writes:
> 
> > As a user interface, that sounds very much desirable.  I don't like
> > converting symbols to strings, putting stuff on them, and converting
> > them back again.
> >
> > But it's probably the lesser evil.
> 
> Actually, use an alist or a hash internally for mapping
> tremolo,volta,whatever to a music type even though it looks like string
> manipulation might do the trick.
> 
> That way you can also get #f and put out an error instead of creating an
> illegal music type.
> 
> And the result is again reasonably efficient.
> 
> -- 
> David Kastrup

Done.
Now a hash-table is used.
I don't think an error is needed, a warning should be sufficient.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b