Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(8604)

Issue 318830043: TBR: Continue suite if git diff fails

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 5 months ago by bruening
Modified:
7 years, 5 months ago
Reviewers:
zhaoqin
CC:
dynamorio-devs_googlegroups.com
Visibility:
Public.

Description

Commit log for first patchset: --------------- Continue suite if git diff fails Turns the failure of obtaining the diff for the test suite into a non-fatal error, to handle failures on buildbots from mixed Cygwin and Windows paths. ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M suite/runsuite.cmake View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 3
bruening
7 years, 5 months ago (2016-11-21 00:44:05 UTC) #1
bruening
Committed as https://github.com/DynamoRIO/dynamorio/commit/a6658ad328664017ad982be9ecce0cab112fb195 Final commit log: --------------- Continue suite if git diff fails Turns the ...
7 years, 5 months ago (2016-11-21 00:44:08 UTC) #2
bruening
7 years, 5 months ago (2016-11-21 01:54:03 UTC) #3
This gets the DR Cr Windows bots running tests again.  All tests pass but
the bot it still red: so there are more recipe problems left.
https://build.chromium.org/p/client.dynamorio/builders/win-7-dr/builds/1498/s...


On Sun, Nov 20, 2016 at 7:44 PM, <reply@codereview-hr.appspotmail.com>
wrote:

> Committed as
> https://github.com/DynamoRIO/dynamorio/commit/a6658ad3286640
> 17ad982be9ecce0cab112fb195
>
> Final commit log:
> ---------------
> Continue suite if git diff fails
>
> Turns the failure of obtaining the diff for the test suite into a
> non-fatal
> error, to handle failures on buildbots from mixed Cygwin and Windows
> paths.
>
> Review-URL: https://codereview.appspot.com/318830043
> ---------------
>
> http://codereview.appspot.com/318830043/
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "DynamoRIO Devs" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to dynamorio-devs+unsubscribe@googlegroups.com.
> To post to this group, send email to dynamorio-devs@googlegroups.com.
> Visit this group at https://groups.google.com/group/dynamorio-devs.
> For more options, visit https://groups.google.com/d/optout.
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b