LGTM https://codereview.appspot.com/318580043/diff/1/Documentation/notation/staff.itely File Documentation/notation/staff.itely (right): https://codereview.appspot.com/318580043/diff/1/Documentation/notation/staff.itely#newcode790 Documentation/notation/staff.itely:790: empty at the same time. This behaviour is ...
On 2017/02/17 05:38:44, lemzwerg wrote:
> ...
Please use two spaces after a full stop that closes a sentence.
Sorry, missed that one. Fixed but without new patch set.
https://codereview.appspot.com/318580043/diff/1/Documentation/notation/staff....
File Documentation/notation/staff.itely (right):
https://codereview.appspot.com/318580043/diff/1/Documentation/notation/staff....
Documentation/notation/staff.itely:793: removed from the @code{PianoStaff}
context to allow individual staves to
Sorry, but that makes no sense. Use GrandStaff instead of PianoStaff if you
don't want a PianoStaff.
Documentation should not focus about how to use the wrong tool for the job. If
you want to document it, do it the other way round: explain how you can keep the
staves of a GrandStaff together and then mention that this behavior is desired
so often for piano that PianoStaff is already separately available.
On 2017/02/17 07:24:42, dak wrote:
>
https://codereview.appspot.com/318580043/diff/1/Documentation/notation/staff....
> File Documentation/notation/staff.itely (right):
>
>
https://codereview.appspot.com/318580043/diff/1/Documentation/notation/staff....
> Documentation/notation/staff.itely:793: removed from the @code{PianoStaff}
> context to allow individual staves to
> Sorry, but that makes no sense. Use GrandStaff instead of PianoStaff if you
> don't want a PianoStaff.
>
> Documentation should not focus about how to use the wrong tool for the job.
If
> you want to document it, do it the other way round: explain how you can keep
the
> staves of a GrandStaff together and then mention that this behavior is desired
> so often for piano that PianoStaff is already separately available.
I don't see how PianoStaff is the wrong tool to notate piano music.
But I will see to rewriting it the other way round.
On 2017/02/17 07:27:27, git wrote:
> On 2017/02/17 07:24:42, dak wrote:
> > Documentation should not focus about how to use the wrong tool for the job.
> > If you want to document it, do it the other way round: explain how you can
keep
> > the staves of a GrandStaff together and then mention that this behavior is
desired
> > so often for piano that PianoStaff is already separately available.
>
> I don't see how PianoStaff is the wrong tool to notate piano music.
>
> But I will see to rewriting it the other way round.
Ok, I'll bite. What kind of piano music is written like
\score {
\new PianoStaff <<
\new Staff = "up" <<
\structure
\v.1
\v.2
>>
\dyn.1
\new Staff = "mid" <<
\structure
\v.3
\v.4
>>
\dyn.2
\new Staff = "lo" <<
\structure
\v.5
>>
>>
}
Because that is the example underlying your report.
Issue 318580043: NR: Document \remove "Keep_alive_together_engraver"
Created 8 years, 1 month ago by git
Modified 8 years, 1 month ago
Reviewers: lemzwerg, dak
Base URL:
Comments: 2