Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(236)

Issue 318580043: NR: Document \remove "Keep_alive_together_engraver"

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 months ago by git
Modified:
7 months ago
Reviewers:
dak, lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

NR: Document \remove "Keep_alive_together_engraver"

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -1 line) Patch
M Documentation/notation/staff.itely View 2 chunks +43 lines, -1 line 2 comments Download

Messages

Total messages: 5
lemzwerg
LGTM https://codereview.appspot.com/318580043/diff/1/Documentation/notation/staff.itely File Documentation/notation/staff.itely (right): https://codereview.appspot.com/318580043/diff/1/Documentation/notation/staff.itely#newcode790 Documentation/notation/staff.itely:790: empty at the same time. This behaviour is ...
7 months ago (2017-02-17 05:38:44 UTC) #1
git
On 2017/02/17 05:38:44, lemzwerg wrote: > ... Please use two spaces after a full stop ...
7 months ago (2017-02-17 07:08:20 UTC) #2
dak
https://codereview.appspot.com/318580043/diff/1/Documentation/notation/staff.itely File Documentation/notation/staff.itely (right): https://codereview.appspot.com/318580043/diff/1/Documentation/notation/staff.itely#newcode793 Documentation/notation/staff.itely:793: removed from the @code{PianoStaff} context to allow individual staves ...
7 months ago (2017-02-17 07:24:42 UTC) #3
git
On 2017/02/17 07:24:42, dak wrote: > https://codereview.appspot.com/318580043/diff/1/Documentation/notation/staff.itely > File Documentation/notation/staff.itely (right): > > https://codereview.appspot.com/318580043/diff/1/Documentation/notation/staff.itely#newcode793 > ...
7 months ago (2017-02-17 07:27:27 UTC) #4
dak
7 months ago (2017-02-17 07:34:46 UTC) #5
On 2017/02/17 07:27:27, git wrote:
> On 2017/02/17 07:24:42, dak wrote:

> > Documentation should not focus about how to use the wrong tool for the job. 
> > If you want to document it, do it the other way round: explain how you can
keep
> > the staves of a GrandStaff together and then mention that this behavior is
desired
> > so often for piano that PianoStaff is already separately available.
> 
> I don't see how PianoStaff is the wrong tool to notate piano music.
> 
> But I will see to rewriting it the other way round.

Ok, I'll bite.  What kind of piano music is written like

\score {
  \new PianoStaff <<
    \new Staff = "up" <<
      \structure
      \v.1
      \v.2
    >>
    \dyn.1
    \new Staff = "mid" <<
      \structure
      \v.3
      \v.4
    >>
    \dyn.2
    \new Staff = "lo" <<
      \structure
      \v.5
    >>
  >>
}

Because that is the example underlying your report.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted