code review 31840043: syscall: Set SizeofSockaddrAny to the value the go dist...

syscall: Set SizeofSockaddrAny to the value the go distribution uses

In particular this means that the names Getsockname returns are not
truncated to 26 characters.

Fixes issue 6829

[mwhudson, 2013-11-25 02:06:47]

Hello gofrontend-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/gofrontend/

[minux1, 2013-11-25 03:10:43]

so the API compatibility guarantee doesn't apply to gccgo?

[mwhudson, 2013-11-25 20:07:06]

I don't really know what that means. All I want is for Getsockname to not
truncate at such a short length :-)


On Mon, Nov 25, 2013 at 4:10 PM, minux <minux.ma@gmail.com> wrote:

> so the API compatibility guarantee doesn't apply to gccgo?
>

[dave_cheney.net, 2013-11-25 21:10:30]

In the gc compiler, the final step of the build is to run a tool
called the 'api tool' which asserts that as we develop the standard
library we don't change the definition of any constants, type or
functions.

I believe the Minux was wondering if gccgo has such a process and if
changing this constant would imply breaking the contract for users of
that constant.

That said, this is pretty clearly a bug, and fixing bugs is allowed
(with consideration) under the Go 1 compatibility guidelines.

On Tue, Nov 26, 2013 at 7:07 AM, Michael Hudson-Doyle
<michael.hudson@linaro.org> wrote:
> I don't really know what that means. All I want is for Getsockname to not
> truncate at such a short length :-)
>
>
> On Mon, Nov 25, 2013 at 4:10 PM, minux <minux.ma@gmail.com> wrote:
>>
>> so the API compatibility guarantee doesn't apply to gccgo?
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "gofrontend-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to gofrontend-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.

[minux1, 2013-11-25 22:13:31]

On Nov 25, 2013 4:10 PM, "Dave Cheney" <dave@cheney.net> wrote:
>
> In the gc compiler, the final step of the build is to run a tool
> called the 'api tool' which asserts that as we develop the standard
> library we don't change the definition of any constants, type or
> functions.
>
> I believe the Minux was wondering if gccgo has such a process and if
> changing this constant would imply breaking the contract for users of
> that constant.
>
> That said, this is pretty clearly a bug, and fixing bugs is allowed
> (with consideration) under the Go 1 compatibility guidelines.
there were occasions in the past that clearly wrong definitions are
preserved and instead new definitions are introduced.

for example, look at the history for the syscall package.
> On Tue, Nov 26, 2013 at 7:07 AM, Michael Hudson-Doyle
> <michael.hudson@linaro.org> wrote:
> > I don't really know what that means. All I want is for Getsockname to
not
> > truncate at such a short length :-)

[iant, 2013-11-25 22:16:34]

LGTM

Many parts of the gccgo syscall package are generated based on the target for
which gccgo is built.  I don't think there is any meaningful way that gccgo can
provide a Go 1 style compatibility guarantee for the syscall package.

In any case I agree that this just seems like a bug fix.

[iant, 2013-11-25 22:53:37]

*** Submitted as
https://code.google.com/p/gofrontend/source/detail?r=bcd0cf1ac784 ***

syscall: Set SizeofSockaddrAny to the value the go distribution uses

In particular this means that the names Getsockname returns are not
truncated to 26 characters.

Fixes issue 6829

R=gofrontend-dev, minux.ma, dave, iant
CC=gofrontend-dev
https://codereview.appspot.com/31840043

Committer: Ian Lance Taylor <iant@golang.org>