Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(9075)

Issue 318370043: TBR: i#1273 use drmgr everywhere: update opcodes to use drmgr

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 2 months ago by bruening
Modified:
7 years, 2 months ago
Reviewers:
zhaoqin
CC:
dynamorio-devs_googlegroups.com
Visibility:
Public.

Description

Commit log for first patchset: --------------- i#1273 use drmgr everywhere: update opcodes to use drmgr Updates the opcodes sample to use drmgr's insertion event, but look ahead to insert all the counters at once. This is the simplest compromise, as strict analysis vs insertion separation would be inefficient here. With drreg's latest optimization of keeping aflags in xax, there is no loss in instrumentation efficiency from this change. ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -37 lines) Patch
M api/samples/CMakeLists.txt View 1 chunk +1 line, -1 line 0 comments Download
M api/samples/opcodes.c View 5 chunks +51 lines, -36 lines 0 comments Download

Messages

Total messages: 2
bruening
7 years, 2 months ago (2017-01-30 06:15:57 UTC) #1
bruening
7 years, 2 months ago (2017-01-30 06:15:59 UTC) #2
Committed as
https://github.com/DynamoRIO/dynamorio/commit/5f23fd859590280c3c519eca8bbddfa...

Final commit log: 
---------------
i#1273 use drmgr everywhere: update opcodes to use drmgr

Updates the opcodes sample to use drmgr's insertion event, but look ahead
to insert all the counters at once.  This is the simplest compromise, as
strict analysis vs insertion separation would be inefficient here.
With drreg's latest optimization of keeping aflags in xax, there is no loss
in instrumentation efficiency from this change.

Review-URL: https://codereview.appspot.com/318370043
---------------
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b