Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6490)

Issue 318280043: i1569: port and enable api/samples/bbbuf.c on AArch64.

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 3 months ago by fhahn
Modified:
7 years, 3 months ago
Reviewers:
bruening
CC:
dynamorio-devs_googlegroups.com
Visibility:
Public.

Description

Commit log for first patchset: --------------- i1569: port and enable api/samples/bbbuf.c on AArch64. AArch64 needs a second scratch register for drx_buf_insert_load_buf_ptr and drx_buf_insert_buf_store, like AArch32. ---------------

Patch Set 1 #

Patch Set 2 : update-message #

Patch Set 3 : add-issue-desc #

Patch Set 4 : commit-msg #

Patch Set 5 : Committed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M api/samples/CMakeLists.txt View 1 chunk +1 line, -3 lines 0 comments Download
M api/samples/bbbuf.c View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9
fhahn
7 years, 3 months ago (2017-01-17 10:55:26 UTC) #1
bruening
On 2017/01/17 10:55:26, fhahn wrote: > i1569: port and enable api/samples/bbbuf.c on AArch64. style: missing ...
7 years, 3 months ago (2017-01-17 13:36:32 UTC) #2
fhahn
Commit log for latest patchset: --------------- i#1569: port and enable api/samples/bbbuf.c on AArch64. AArch64 needs ...
7 years, 3 months ago (2017-01-17 13:45:48 UTC) #3
bruening
On 2017/01/17 13:45:48, fhahn wrote: > Commit log for latest patchset: > --------------- > i#1569: ...
7 years, 3 months ago (2017-01-17 14:22:35 UTC) #4
fhahn
Commit log for latest patchset: --------------- i#1569 add AArch64 support: port and enable api/samples/bbbuf.c AArch64 ...
7 years, 3 months ago (2017-01-17 14:31:02 UTC) #5
fhahn
Commit log for latest patchset: --------------- i#1569 AArch64: Port and enable api/samples/bbbuf.c AArch64 needs a ...
7 years, 3 months ago (2017-01-17 14:33:04 UTC) #6
fhahn
On 2017/01/17 14:22:35, bruening wrote: > On 2017/01/17 13:45:48, fhahn wrote: > > Commit log ...
7 years, 3 months ago (2017-01-17 14:33:27 UTC) #7
bruening
Thanks for fixing the little style convention issues. LGTM
7 years, 3 months ago (2017-01-17 14:44:58 UTC) #8
fhahn
7 years, 3 months ago (2017-01-23 17:07:35 UTC) #9
Committed as
https://github.com/DynamoRIO/dynamorio/commit/5fb47e7dd698e7f01f85b6724692bc1...

Final commit log: 
---------------
i#1569 AArch64: Port and enable api/samples/bbbuf.c

AArch64 needs a second scratch register for drx_buf_insert_load_buf_ptr
and drx_buf_insert_buf_store, like AArch32.

Review-URL: https://codereview.appspot.com/318280043
---------------
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b