Issue 318250043: TBR: i#2127, i#1374: eliminate UNIX symlink library versioning

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 318250043: TBR: i#2127, i#1374: eliminate UNIX symlink library versioning

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 3 months ago by bruening

Modified:
7 years, 3 months ago

Reviewers:
zhaoqin

CC:
dynamorio-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- i#2127, i#1374: eliminate UNIX symlink library versioning Eliminates libdynamorio.so versioning on UNIX platforms to avoid numerous problems (i#2127: hardcoded DT_NEEDED, i#1374: similar issues on Mac, Android symlink limitations). These versions were not providing much benefit, as we weren't using the system loader. Our own loader provides its own client version compatibility checks versus the libdynamorio.so version. Leaves the version properties on Windows as they're useful there as library attributes. Fixes #2127 Fixes #1374 ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -59 lines)			Patch
	M	core/CMakeLists.txt	View		3 chunks	+6 lines, -39 lines	0 comments	Download
	M	tools/CMakeLists.txt	View		2 chunks	+10 lines, -20 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bruening

7 years, 3 months ago (2017-01-09 22:16:09 UTC) #2

Committed as
https://github.com/DynamoRIO/dynamorio/commit/d4c6ad58673789bfc575c456799e192...

Final commit log: 
---------------
i#2127, i#1374: eliminate UNIX symlink library versioning

Eliminates libdynamorio.so versioning on UNIX platforms to avoid numerous
problems (i#2127: hardcoded DT_NEEDED, i#1374: similar issues on Mac,
Android symlink limitations).  These versions were not providing much
benefit, as we weren't using the system loader.  Our own loader provides
its own client version compatibility checks versus the libdynamorio.so
version.

Leaves the version properties on Windows as they're useful there as library
attributes.

Fixes #2127
Fixes #1374

Review-URL: https://codereview.appspot.com/318250043
---------------

Expand All Messages | Collapse All Messages