[plaso] Added memory usage to status view

[plaso] Added memory usage to status view

[Joachim Metz, 2017-01-10 20:27:33]

Code updated.

[onager, 2017-01-13 11:51:40]

https://codereview.appspot.com/318240043/diff/20001/plaso/cli/status_view_too...
File plaso/cli/status_view_tool.py (right):

https://codereview.appspot.com/318240043/diff/20001/plaso/cli/status_view_too...
plaso/cli/status_view_tool.py:90: magnitude_1024 = 0
It's not clear exactly what this is doing - can you refactor this to a separate
method?

https://codereview.appspot.com/318240043/diff/20001/plaso/engine/process_info.py
File plaso/engine/process_info.py (right):

https://codereview.appspot.com/318240043/diff/20001/plaso/engine/process_info...
plaso/engine/process_info.py:8: """Class that provides information about a
running process."""
-Class that

https://codereview.appspot.com/318240043/diff/20001/plaso/engine/process_info...
plaso/engine/process_info.py:11: """Initialize a process information object.
Initializes

https://codereview.appspot.com/318240043/diff/20001/plaso/engine/process_info...
plaso/engine/process_info.py:35: int: amount of memory used by the process or
None if not available.
in bytes?

https://codereview.appspot.com/318240043/diff/20001/plaso/multi_processing/en...
File plaso/multi_processing/engine.py (right):

https://codereview.appspot.com/318240043/diff/20001/plaso/multi_processing/en...
plaso/multi_processing/engine.py:266: if the process if the processed is already
being monitored.
-if the processed

[Joachim Metz, 2017-01-15 08:27:05]

https://codereview.appspot.com/318240043/diff/20001/plaso/cli/status_view_too...
File plaso/cli/status_view_tool.py (right):

https://codereview.appspot.com/318240043/diff/20001/plaso/cli/status_view_too...
plaso/cli/status_view_tool.py:90: magnitude_1024 = 0
On 2017/01/13 11:51:40, onager wrote:
> It's not clear exactly what this is doing - can you refactor this to a
separate
> method?

Done.

https://codereview.appspot.com/318240043/diff/20001/plaso/engine/process_info.py
File plaso/engine/process_info.py (right):

https://codereview.appspot.com/318240043/diff/20001/plaso/engine/process_info...
plaso/engine/process_info.py:8: """Class that provides information about a
running process."""
On 2017/01/13 11:51:40, onager wrote:
> -Class that

Done.

https://codereview.appspot.com/318240043/diff/20001/plaso/engine/process_info...
plaso/engine/process_info.py:11: """Initialize a process information object.
On 2017/01/13 11:51:40, onager wrote:
> Initializes

Done.

https://codereview.appspot.com/318240043/diff/20001/plaso/engine/process_info...
plaso/engine/process_info.py:35: int: amount of memory used by the process or
None if not available.
On 2017/01/13 11:51:40, onager wrote:
> in bytes?

Done.

https://codereview.appspot.com/318240043/diff/20001/plaso/multi_processing/en...
File plaso/multi_processing/engine.py (right):

https://codereview.appspot.com/318240043/diff/20001/plaso/multi_processing/en...
plaso/multi_processing/engine.py:266: if the process if the processed is already
being monitored.
On 2017/01/13 11:51:40, onager wrote:
> -if the processed

Done.

[Joachim Metz, 2017-01-15 08:33:39]

Code updated.

[onager, 2017-01-16 14:56:06]

LGTM

[Joachim Metz, 2017-01-16 18:32:09]

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close memusage