Issue 318130043: [dftimewolf] A bit of cleanup.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 318130043: [dftimewolf] A bit of cleanup. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 4 months ago by someguyiknow

Modified:
7 years, 3 months ago

Reviewers:
Joachim Metz, jberggren, romaing, onager

CC:
kiddi, log2timeline-dev_googlegroups.com

Visibility:
Public.

More Reviews

Patch Set 2 : Properly populate reason for timesketch export. #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -26 lines)			Patch
M	dftimewolf/lib/collectors.py	View		3 chunks	+3 lines, -6 lines	0 comments	Download
M	dftimewolf/lib/processors.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	dftimewolf/timewolf_cli.py	View	1	3 chunks	+6 lines, -5 lines	0 comments	Download
M	dftimewolf/timewolf_collect.py	View		4 chunks	+5 lines, -5 lines	0 comments	Download
M	dftimewolf/timewolf_export.py	View	1	4 chunks	+8 lines, -5 lines	0 comments	Download
M	dftimewolf/timewolf_process.py	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

jberggren

Just a couple of comments, no blockers though. LGTM https://codereview.appspot.com/318130043/diff/1/dftimewolf/timewolf_export.py File dftimewolf/timewolf_export.py (right): https://codereview.appspot.com/318130043/diff/1/dftimewolf/timewolf_export.py#newcode76 dftimewolf/timewolf_export.py:76: ...

7 years, 4 months ago (2016-12-27 12:14:04 UTC) #2

someguyiknow

https://codereview.appspot.com/318130043/diff/1/dftimewolf/timewolf_export.py File dftimewolf/timewolf_export.py (right): https://codereview.appspot.com/318130043/diff/1/dftimewolf/timewolf_export.py#newcode76 dftimewolf/timewolf_export.py:76: sketch_name = FLAGS.reason or u'default' On 2016/12/27 12:14:04, jberggren ...

7 years, 3 months ago (2017-01-19 14:35:32 UTC) #4

someguyiknow

7 years, 3 months ago (2017-01-19 14:42:32 UTC) #5

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close cleanup

Expand All Messages | Collapse All Messages