Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7942)

Issue 317970043: i#1803 flaky signest test: delay the second signal.

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 5 months ago by zhaoqin
Modified:
7 years, 4 months ago
Reviewers:
bruening
CC:
dynamorio-devs_googlegroups.com
Visibility:
Public.

Description

Commit log for first patchset: --------------- i#1803 flaky signest test: delay the second signal. Updates test signest to delay sending the second signal utill the first signal is delivered. ---------------

Patch Set 1 #

Total comments: 3

Patch Set 2 : Update comment #

Patch Set 3 : Committed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M suite/tests/linux/signest.c View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4
zhaoqin
7 years, 5 months ago (2016-11-27 01:22:16 UTC) #1
bruening
Please make it clear in the commit message *why* this is being done: that it's ...
7 years, 4 months ago (2016-12-01 04:38:05 UTC) #2
zhaoqin
Commit log for latest patchset: --------------- i#1803 flaky signest test: delay the second signal as ...
7 years, 4 months ago (2016-12-01 15:46:30 UTC) #3
zhaoqin
7 years, 4 months ago (2016-12-01 16:26:42 UTC) #4
Committed as
https://github.com/DynamoRIO/dynamorio/commit/ac059a51bdc21a6ff138f098e92b334...

Final commit log: 
---------------
i#1803 flaky signest test: delay the second signal as a temporary workaround

DR may incorrectly drop the signal if more than one are delivered together.
We update the signest test to delay sending the second signal until
the first one is delivered as a temporary workaround.

Review-URL: https://codereview.appspot.com/317970043
---------------
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b