Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5850)

Issue 317920043: TBR: i#1729 offline traces: add headers and footers

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 5 months ago by bruening
Modified:
7 years, 5 months ago
Reviewers:
zhaoqin
CC:
dynamorio-devs_googlegroups.com
Visibility:
Public.

Description

Commit log for first patchset: --------------- i#1729 offline traces: add headers and footers Adds a header and footer type to each of the offline raw and finished trace file formats. Adds a version field to the headers to facilitate changing the format in the future. Uses the footer to ensure that files are not truncated by changing the readers to look for the footer rather than just EOF and to complain on EOF. Changes the analyzer to seek ahead and look for the footer on an existing finished trace file to ensure we re-run drraw2trace if an earlier run was interrupted, ran out of disk space, or whatnot: we only use a file already present if it has a footer. Adds a mechanism to skip the max size check when writing the footer to ensure each thread has a footer. ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -31 lines) Patch
M clients/drcachesim/analyzer.cpp View 1 chunk +6 lines, -4 lines 0 comments Download
M clients/drcachesim/common/trace_entry.h View 4 chunks +26 lines, -3 lines 0 comments Download
M clients/drcachesim/reader/file_reader.h View 1 chunk +1 line, -0 lines 0 comments Download
M clients/drcachesim/reader/file_reader.cpp View 2 chunks +24 lines, -0 lines 0 comments Download
M clients/drcachesim/reader/ipc_reader.cpp View 1 chunk +8 lines, -1 line 0 comments Download
M clients/drcachesim/reader/reader.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M clients/drcachesim/tracer/instru.h View 3 chunks +6 lines, -3 lines 0 comments Download
M clients/drcachesim/tracer/instru_offline.cpp View 2 chunks +17 lines, -4 lines 0 comments Download
M clients/drcachesim/tracer/instru_online.cpp View 1 chunk +8 lines, -1 line 0 comments Download
M clients/drcachesim/tracer/raw2trace.cpp View 3 chunks +44 lines, -6 lines 0 comments Download
M clients/drcachesim/tracer/tracer.cpp View 6 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 1
bruening
7 years, 5 months ago (2016-11-11 06:22:09 UTC) #1
Committed as
https://github.com/DynamoRIO/dynamorio/commit/9bed8755277b6afd9992b90a8e3c2c7...

Final commit log: 
---------------
i#1729 offline traces: add headers and footers

Adds a header and footer type to each of the offline raw and finished trace
file formats.

Adds a version field to the headers to facilitate changing
the format in the future.

Uses the footer to ensure that files are not truncated by changing the
readers to look for the footer rather than just EOF and to complain on EOF.

Changes the analyzer to seek ahead and look for the footer on an existing
finished trace file to ensure we re-run drraw2trace if an earlier run was
interrupted, ran out of disk space, or whatnot: we only use a file already
present if it has a footer.

Adds a mechanism to skip the max size check when writing the footer to
ensure each thread has a footer.

Review-URL: https://codereview.appspot.com/317920043
---------------
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b