Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1810)

Issue 317760043: Method _add_transaction could be called with None kwargs

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 6 months ago by sergio.morillo
Modified:
7 years, 6 months ago
Reviewers:
ced
Visibility:
Public.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix AttributeError when calling kwargs.copy() #

Patch Set 3 : Method _add_transaction could be called with None kwargs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M celery_tryton.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7
sergio.morillo
7 years, 6 months ago (2016-10-21 07:22:49 UTC) #1
ced
https://codereview.appspot.com/317760043/diff/1/celery_tryton.py File celery_tryton.py (right): https://codereview.appspot.com/317760043/diff/1/celery_tryton.py#newcode107 celery_tryton.py:107: kwargs = kwargs.copy() I would test here is kwargs ...
7 years, 6 months ago (2016-10-21 16:50:18 UTC) #2
ced
Also I think the description of the issue should be more complete. It should not ...
7 years, 6 months ago (2016-10-21 16:52:50 UTC) #3
sergio.morillo
Fix AttributeError when calling kwargs.copy()
7 years, 6 months ago (2016-10-21 21:32:25 UTC) #4
ced
LGTM but a better commit message should be written.
7 years, 6 months ago (2016-10-22 17:37:37 UTC) #5
sergio.morillo
Method _add_transaction could be called with None kwargs
7 years, 6 months ago (2016-10-24 06:59:16 UTC) #6
sergio.morillo
7 years, 6 months ago (2016-10-24 07:01:52 UTC) #7
On 2016/10/22 17:37:37, ced wrote:
> LGTM but a better commit message should be written.

Sorry, I have just seen the review was committed.
Thanks.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b