Issue 317730043: TBR: i#2034 app API threads: take over secondary thread

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 317730043: TBR: i#2034 app API threads: take over secondary thread

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 11 months ago by bruening

Modified:
9 years, 11 months ago

Reviewers:
zhaoqin

CC:
dynamorio-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- i#2034 app API threads: take over secondary thread Adds support for a different thread calling dr_app_start() from the thread that called dr_app_setup(). We initialize the calling thread if it's not already initialized, and point at the primary thread's signal handling info. A test is forthcoming as part of i#1729. Fixes #2034 ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -5 lines)			Patch
M	core/arch/x86_code.c	View	1 chunk	+12 lines, -1 line	0 comments	Download
M	core/dynamo.c	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	core/globals.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	core/os_shared.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	core/unix/os.c	View	2 chunks	+22 lines, -0 lines	0 comments	Download
M	core/win32/os.c	View	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bruening

9 years, 11 months ago (2016-10-20 18:51:14 UTC) #2

Committed as
https://github.com/DynamoRIO/dynamorio/commit/beb9eeaddc9177b0cb867642803a835...

Final commit log: 
---------------
i#2034 app API threads: take over secondary thread

Adds support for a different thread calling dr_app_start() from the thread
that called dr_app_setup().  We initialize the calling thread if it's not
already initialized, and point at the primary thread's signal handling
info.

A test is forthcoming as part of i#1729.

Fixes #2034

Review-URL: https://codereview.appspot.com/317730043
---------------

Expand All Messages | Collapse All Messages