Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1291)

Issue 317710043: ticket:13228 Adding more symbols to standard/localized pattern mapping function (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 10 months ago by sffc
Modified:
6 years, 10 months ago
Reviewers:
andy.heninger
CC:
yoshito_umaoka_us.ibm.com, yoshito
Base URL:
svn+icussh://source.icu-project.org/repos/icu/trunk/
Visibility:
Public.

Description

ticket:13228 Adding more symbols to standard/localized pattern mapping function

Patch Set 1 #

Patch Set 2 : Changing from code point conversion to string conversion #

Patch Set 3 : Updating ICU4C copy of numberformattestspecification.txt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -77 lines) Patch
M icu4c/source/test/testdata/numberformattestspecification.txt View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/impl/number/PatternString.java View 1 2 chunks +117 lines, -76 lines 0 comments Download
M icu4j/main/tests/core/src/com/ibm/icu/dev/data/numberformattestspecification.txt View 1 1 chunk +12 lines, -0 lines 0 comments Download
M icu4j/main/tests/core/src/com/ibm/icu/dev/test/format/NumberFormatDataDrivenTest.java View 1 1 chunk +4 lines, -1 line 0 comments Download
M icu4j/main/tests/core/src/com/ibm/icu/dev/test/format/NumberFormatTest.java View 1 2 chunks +54 lines, -0 lines 0 comments Download

Messages

Total messages: 8
sffc
6 years, 10 months ago (2017-06-07 23:07:11 UTC) #1
andy.heninger
LGTM
6 years, 10 months ago (2017-06-14 20:40:57 UTC) #2
sffc
Changing from code point conversion to string conversion
6 years, 10 months ago (2017-06-15 01:29:54 UTC) #3
sffc
Andy: Please re-review with the new string-based code.
6 years, 10 months ago (2017-06-15 01:30:20 UTC) #4
sffc
Updating ICU4C copy of numberformattestspecification.txt
6 years, 10 months ago (2017-06-15 01:33:00 UTC) #5
sffc
Ping Andy
6 years, 10 months ago (2017-06-20 09:16:17 UTC) #6
andy.heninger
LGTM
6 years, 10 months ago (2017-06-21 00:35:00 UTC) #7
sffc
6 years, 10 months ago (2017-06-21 00:38:34 UTC) #8
On 2017/06/21 00:35:00, andy.heninger wrote:
> LGTM

Committed revision 40185.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b