Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1900)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 317520043: [dfwinreg] Updated utility scripts (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years ago by Joachim Metz
Modified:
7 years ago
Reviewers:
onager
CC:
kiddi, log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

[dfwinreg] Updated utility scripts

Patch Set 1 : Updated utility scripts #

Total comments: 2

Patch Set 2 : Updated utility scripts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+347 lines, -142 lines) Patch
M appveyor.yml View 1 chunk +3 lines, -3 lines 0 comments Download
M config/dpkg/control View 1 chunk +1 line, -1 line 0 comments Download
M config/travis/install.sh View 1 2 chunks +10 lines, -2 lines 0 comments Download
M dfwinreg/dependencies.py View 2 chunks +22 lines, -1 line 0 comments Download
M requirements.txt View 1 chunk +2 lines, -1 line 0 comments Download
M run_tests.py View 2 chunks +2 lines, -2 lines 0 comments Download
M utils/review.py View 44 chunks +198 lines, -100 lines 0 comments Download
M utils/update_dependencies.py View 1 7 chunks +109 lines, -32 lines 0 comments Download

Messages

Total messages: 9
Joachim Metz
7 years ago (2017-04-19 20:15:42 UTC) #1
Joachim Metz
Code updated.
7 years ago (2017-04-19 20:17:47 UTC) #2
Joachim Metz
Code updated.
7 years ago (2017-04-19 20:38:47 UTC) #3
Joachim Metz
https://codereview.appspot.com/317520043/diff/40001/config/travis/install.sh File config/travis/install.sh (right): https://codereview.appspot.com/317520043/diff/40001/config/travis/install.sh#newcode25 config/travis/install.sh:25: PYTHONPATH=../l2tdevtools ../l2tdevtools/tools/update.py --download-directory=dependencies --preset=dfwinreg; switch from preset to individual ...
7 years ago (2017-04-19 20:54:05 UTC) #4
Joachim Metz
Code updated.
7 years ago (2017-04-21 03:47:45 UTC) #5
Joachim Metz
https://codereview.appspot.com/317520043/diff/40001/config/travis/install.sh File config/travis/install.sh (right): https://codereview.appspot.com/317520043/diff/40001/config/travis/install.sh#newcode25 config/travis/install.sh:25: PYTHONPATH=../l2tdevtools ../l2tdevtools/tools/update.py --download-directory=dependencies --preset=dfwinreg; On 2017/04/19 20:54:05, Joachim Metz ...
7 years ago (2017-04-21 03:47:50 UTC) #6
Joachim Metz
Code updated.
7 years ago (2017-04-21 03:57:03 UTC) #7
onager
LGTM
7 years ago (2017-04-21 06:48:42 UTC) #8
Joachim Metz
7 years ago (2017-04-22 13:13:18 UTC) #9 
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close utils
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b