Hardcode shadow-play-services ShadowProvider config.

Hardcode shadow-play-services ShadowProvider config.

This file is normally generated at compile-time by Robolectric.
This is tricky to do in GN. The file will never change so we
might as well hardcode it.

BUG=693660
R=jbudorick@chromium.org

Committed: 2a0b6ba221c14f3371813a676ce06143353e448d

[mikecase, 2017-03-20 21:07:50]

Need this to build shadow-play-services in Chromium.

[jbudorick, 2017-03-20 22:34:13]

When is this required for shadow-play-services? At build time?

Also, can you add a bug number?

[yolandyan, 2017-03-20 23:17:01]

hmm, do I need to be an OWNER to review this?

[mikecase, 2017-03-21 18:08:16]

On 2017/03/20 23:17:01, yolandyan wrote:
> hmm, do I need to be an OWNER to review this?

[mikecase, 2017-03-21 18:12:35]

On 2017/03/21 18:08:16, mikecase wrote:
> On 2017/03/20 23:17:01, yolandyan wrote:
> > hmm, do I need to be an OWNER to review this?

oops. I just all the text I wrote. Arrrrrrrrrgggg.

OK. Round two. Caps to help readability.


This is required at RUNTIME. Java has a plug-in system...
https://docs.oracle.com/javase/tutorial/ext/basics/spi.html

Java, at RUNTIME is going to look for a class that implements ShadowProvider
interface...
https://github.com/robolectric/robolectric/blob/e81c5849919b576f8e9d5ff41f7ad...

The file that implements this interface, org.robolectric.shadows.gms.Shadows, is
generated at COMPILE-TIME. That is probably why they also decided to
auto-generate this config.


GN picks up the auto-gen *.java files. But does not pick up this auto-gen
config.

[mikecase, 2017-03-21 18:15:37]

On 2017/03/21 18:12:35, mikecase wrote:
> On 2017/03/21 18:08:16, mikecase wrote:
> > On 2017/03/20 23:17:01, yolandyan wrote:
> > > hmm, do I need to be an OWNER to review this?
> 
> oops. I just all the text I wrote. Arrrrrrrrrgggg.
> 
> OK. Round two. Caps to help readability.
> 
> 
> This is required at RUNTIME. Java has a plug-in system...
> https://docs.oracle.com/javase/tutorial/ext/basics/spi.html
> 
> Java, at RUNTIME is going to look for a class that implements ShadowProvider
> interface...
>
https://github.com/robolectric/robolectric/blob/e81c5849919b576f8e9d5ff41f7ad...
> 
> The file that implements this interface, org.robolectric.shadows.gms.Shadows,
is
> generated at COMPILE-TIME. That is probably why they also decided to
> auto-generate this config.
> 
> 
> GN picks up the auto-gen *.java files. But does not pick up this auto-gen
> config.

Also, @Yoland, you just have to be a committer to review this... hint hint

[jbudorick, 2017-03-21 18:16:16]

lgtm

I'm skeptical about the "never" change part but am ok with this for now.

[mikecase, 2017-03-27 22:12:16]

Committed patchset #2 (id:20001) manually as
2a0b6ba221c14f3371813a676ce06143353e448d (presubmit successful).