Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(13)

Issue 317270043: Add lilypond version predicates/operators

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months, 2 weeks ago by git
Modified:
5 months ago
Reviewers:
dak, thomasmorley651, pwm
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Add lilypond version predicates/operators This set of predicates/operators compares a given reference version to the LilyPond version that is currently being executed. This makes it possible to implement "version switches" to write (library) code that is compatible over syntax changes. NOTE: I'm not sure where (and if) this should be documented. Please make suggestions

Patch Set 1 #

Total comments: 2

Patch Set 2 : Reflect discussions. #

Total comments: 4

Patch Set 3 : Lexicographic comparison and ly:version? wrapper #

Total comments: 5

Patch Set 4 : Rename secondary function after discussion #

Patch Set 5 : Fix omission of previous patch set #

Patch Set 6 : Limit ly:version? to number list (as suggested by Paul) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M scm/lily-library.scm View 1 2 3 4 5 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 26
dak
https://codereview.appspot.com/317270043/diff/1/scm/lily-library.scm File scm/lily-library.scm (right): https://codereview.appspot.com/317270043/diff/1/scm/lily-library.scm#newcode894 scm/lily-library.scm:894: (define (calculate-version ref-version) This seems overly complicated. Why not ...
5 months, 1 week ago (2017-02-14 14:10:55 UTC) #1
pwm
https://codereview.appspot.com/317270043/diff/1/scm/lily-library.scm File scm/lily-library.scm (right): https://codereview.appspot.com/317270043/diff/1/scm/lily-library.scm#newcode909 scm/lily-library.scm:909: (define-public (lilypond>? ref-version) Instead of a separate procedure for ...
5 months, 1 week ago (2017-02-14 15:00:10 UTC) #2
git
I'm choking a little bit with having the operator as the first argument instead of ...
5 months, 1 week ago (2017-02-14 15:12:25 UTC) #3
git
On 2017/02/14 15:00:10, pwm wrote: > https://codereview.appspot.com/317270043/diff/1/scm/lily-library.scm > File scm/lily-library.scm (right): > > https://codereview.appspot.com/317270043/diff/1/scm/lily-library.scm#newcode909 > ...
5 months, 1 week ago (2017-02-14 15:15:07 UTC) #4
pwm
On 2017/02/14 15:15:07, git wrote: > I like this more because it's more of a ...
5 months, 1 week ago (2017-02-14 15:37:35 UTC) #5
git
On 2017/02/14 15:37:35, pwm wrote: > On 2017/02/14 15:15:07, git wrote: > > I like ...
5 months, 1 week ago (2017-02-14 15:46:20 UTC) #6
dak
On 2017/02/14 15:37:35, pwm wrote: > On 2017/02/14 15:15:07, git wrote: > > I like ...
5 months, 1 week ago (2017-02-14 15:48:02 UTC) #7
dak
On 2017/02/14 15:46:20, git wrote: > On 2017/02/14 15:37:35, pwm wrote: > > On 2017/02/14 ...
5 months, 1 week ago (2017-02-14 15:49:26 UTC) #8
dak
On 2017/02/14 15:49:26, dak wrote: > On 2017/02/14 15:46:20, git wrote: > > On 2017/02/14 ...
5 months, 1 week ago (2017-02-14 15:51:13 UTC) #9
git
> > > However, I found an issue in David's suggestion, namely the > > ...
5 months, 1 week ago (2017-02-14 16:11:55 UTC) #10
dak
On 2017/02/14 15:51:13, dak wrote: > On 2017/02/14 15:49:26, dak wrote: > > On 2017/02/14 ...
5 months, 1 week ago (2017-02-14 16:29:51 UTC) #11
git
Reflect discussions.
5 months, 1 week ago (2017-02-14 17:00:09 UTC) #12
dak
https://codereview.appspot.com/317270043/diff/20001/scm/lily-library.scm File scm/lily-library.scm (right): https://codereview.appspot.com/317270043/diff/20001/scm/lily-library.scm#newcode899 scm/lily-library.scm:899: (let* ((a (car v1)) (b (car v2)) Requires v1/v2 ...
5 months, 1 week ago (2017-02-14 17:29:33 UTC) #13
git
https://codereview.appspot.com/317270043/diff/20001/scm/lily-library.scm File scm/lily-library.scm (right): https://codereview.appspot.com/317270043/diff/20001/scm/lily-library.scm#newcode899 scm/lily-library.scm:899: (let* ((a (car v1)) (b (car v2)) On 2017/02/14 ...
5 months, 1 week ago (2017-02-14 18:20:56 UTC) #14
dak
On 2017/02/14 18:20:56, git wrote: > Ah yes. I had removed the > (and (eq? ...
5 months, 1 week ago (2017-02-14 19:55:02 UTC) #15
thomasmorley651
To throw in my own 2cts. Why not compare strings, looks more straight forward to ...
5 months, 1 week ago (2017-02-14 21:03:19 UTC) #16
thomasmorley651
On 2017/02/14 21:03:19, thomasmorley651 wrote: > To throw in my own 2cts. > > Why ...
5 months, 1 week ago (2017-02-14 21:08:48 UTC) #17
thomasmorley651
On 2017/02/14 21:08:48, thomasmorley651 wrote: > > The issue I can imagine: probably more expensive, ...
5 months, 1 week ago (2017-02-14 21:37:34 UTC) #18
dak
thomasmorley65@gmail.com writes: > To throw in my own 2cts. > > Why not compare strings, ...
5 months, 1 week ago (2017-02-14 23:25:56 UTC) #19
git
Lexicographic comparison and ly:version? wrapper
5 months, 1 week ago (2017-02-15 07:54:52 UTC) #20
pwm
https://codereview.appspot.com/317270043/diff/40001/scm/lily-library.scm File scm/lily-library.scm (right): https://codereview.appspot.com/317270043/diff/40001/scm/lily-library.scm#newcode895 scm/lily-library.scm:895: "Lexicographically compare to lists @var{a} and @var{b} using I ...
5 months, 1 week ago (2017-02-18 15:36:22 UTC) #21
git
https://codereview.appspot.com/317270043/diff/40001/scm/lily-library.scm File scm/lily-library.scm (right): https://codereview.appspot.com/317270043/diff/40001/scm/lily-library.scm#newcode895 scm/lily-library.scm:895: "Lexicographically compare to lists @var{a} and @var{b} using On ...
5 months, 1 week ago (2017-02-18 16:08:10 UTC) #22
git
Rename secondary function after discussion
5 months, 1 week ago (2017-02-18 16:19:16 UTC) #23
git
Fix omission of previous patch set
5 months, 1 week ago (2017-02-18 16:20:34 UTC) #24
dak
https://codereview.appspot.com/317270043/diff/40001/scm/lily-library.scm File scm/lily-library.scm (right): https://codereview.appspot.com/317270043/diff/40001/scm/lily-library.scm#newcode895 scm/lily-library.scm:895: "Lexicographically compare to lists @var{a} and @var{b} using On ...
5 months, 1 week ago (2017-02-18 16:25:06 UTC) #25
git
5 months ago (2017-02-21 11:43:39 UTC) #26
Limit ly:version? to number list (as suggested by Paul)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted