Issue 317100043: TBR: Add shared translation clearing test

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 317100043: TBR: Add shared translation clearing test

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 3 months ago by bruening

Modified:
7 years, 3 months ago

Reviewers:
zhaoqin

CC:
drmemory-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- Add shared translation clearing test Adds a test of clearing of the shared translation value to handle a slowpath trip with subsequent sharers. This test is complex but it will help catch regressions in future refactoring work. ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+102 lines, -62 lines)			Patch
M	tests/addronly-reg.res	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	tests/registers.c	View	4 chunks	+37 lines, -1 line	0 comments	Download
M	tests/registers.out	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/registers.res	View	3 chunks	+45 lines, -41 lines	0 comments	Download
M	tests/registers.blacklist.res	View	1 chunk	+8 lines, -8 lines	0 comments	Download
M	tests/registers.pattern.res	View	1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bruening

7 years, 3 months ago (2017-01-13 05:23:14 UTC) #2

Committed as
https://github.com/DynamoRIO/drmemory/commit/509aeeef459fb3efa25f8796fff8c67f...

Final commit log: 
---------------
Add shared translation clearing test

Adds a test of clearing of the shared translation value to handle a
slowpath trip with subsequent sharers.  This test is complex but it will
help catch regressions in future refactoring work.

Review-URL: https://codereview.appspot.com/317100043
---------------

Expand All Messages | Collapse All Messages