[plaso] Fix bug in GenerateStorageFileName when the source to process ends with a /

[plaso] Fix bug in GenerateStorageFileName when the source to process ends with a /

[Joachim Metz, 2016-12-23 15:06:30]

https://codereview.appspot.com/317020043/diff/1/plaso/cli/extract_analyze_too...
File plaso/cli/extract_analyze_tool.py (right):

https://codereview.appspot.com/317020043/diff/1/plaso/cli/extract_analyze_too...
plaso/cli/extract_analyze_tool.py:40: if source_name == '':
I opt:

source_name = self._source_path
if source_name.endswith(os.path.sep):
   source_name = os.path.dirname(source_name)

source_name = os.path.basename(source_name)

https://codereview.appspot.com/317020043/diff/1/tests/cli/extract_analyze_too...
File tests/cli/extract_analyze_tool.py (right):

https://codereview.appspot.com/317020043/diff/1/tests/cli/extract_analyze_too...
tests/cli/extract_analyze_tool.py:61: 
- white line

[romaing, 2016-12-23 16:01:06]

Code updated.

[romaing, 2016-12-23 16:14:39]

Code updated.

[romaing, 2016-12-23 16:14:53]

https://codereview.appspot.com/317020043/diff/1/plaso/cli/extract_analyze_too...
File plaso/cli/extract_analyze_tool.py (right):

https://codereview.appspot.com/317020043/diff/1/plaso/cli/extract_analyze_too...
plaso/cli/extract_analyze_tool.py:40: if source_name == '':
On 2016/12/23 15:06:30, Joachim Metz wrote:
> I opt:
> 
> source_name = self._source_path
> if source_name.endswith(os.path.sep):
>    source_name = os.path.dirname(source_name)
> 
> source_name = os.path.basename(source_name)

Reworked this a bit:
* Using realpath to resolve ".."
* Check endswith(os.path.sep)
* use "ROOT" when source points to the FS' root

https://codereview.appspot.com/317020043/diff/1/tests/cli/extract_analyze_too...
File tests/cli/extract_analyze_tool.py (right):

https://codereview.appspot.com/317020043/diff/1/tests/cli/extract_analyze_too...
tests/cli/extract_analyze_tool.py:61: 
On 2016/12/23 15:06:30, Joachim Metz wrote:
> - white line

Done.

[Joachim Metz, 2016-12-23 16:40:03]

Some suggestions, otherwise LGTM

https://codereview.appspot.com/317020043/diff/40001/plaso/cli/extract_analyze...
File plaso/cli/extract_analyze_tool.py (right):

https://codereview.appspot.com/317020043/diff/40001/plaso/cli/extract_analyze...
plaso/cli/extract_analyze_tool.py:40: source_path =
os.path.realpath(self._source_path)
Know that realpath will resolve symbolic links, I suggest using abspath instead
to preserve link names.

https://codereview.appspot.com/317020043/diff/40001/plaso/cli/extract_analyze...
plaso/cli/extract_analyze_tool.py:41: source_name =
os.path.basename(source_path)
You can make this more compact

if source_path.endswith(os.path.sep):
   source_path = os.path.dirname(source_path)

if source_path = os.path.sep:
  # The user passed the filesystem's root as source
  source_name = u'ROOT'
else:
  source_name = os.path.basename(source_path)

[Joachim Metz, 2016-12-23 16:40:37]

btw "if source_path = os.path.sep:" should be "if source_path == os.path.sep:"

[romaing, 2017-01-03 12:18:33]

Code updated.

[romaing, 2017-01-03 12:18:52]

https://codereview.appspot.com/317020043/diff/40001/plaso/cli/extract_analyze...
File plaso/cli/extract_analyze_tool.py (right):

https://codereview.appspot.com/317020043/diff/40001/plaso/cli/extract_analyze...
plaso/cli/extract_analyze_tool.py:40: source_path =
os.path.realpath(self._source_path)
On 2016/12/23 16:40:03, Joachim Metz wrote:
> Know that realpath will resolve symbolic links, I suggest using abspath
instead
> to preserve link names.

Done.

https://codereview.appspot.com/317020043/diff/40001/plaso/cli/extract_analyze...
plaso/cli/extract_analyze_tool.py:41: source_name =
os.path.basename(source_path)
On 2016/12/23 16:40:03, Joachim Metz wrote:
> You can make this more compact
> 
> if source_path.endswith(os.path.sep):
>    source_path = os.path.dirname(source_path)
> 
> if source_path = os.path.sep:
>   # The user passed the filesystem's root as source
>   source_name = u'ROOT'
> else:
>   source_name = os.path.basename(source_path)
> 

Done.

[romaing, 2017-01-03 13:39:18]

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close
psteal-storage-filename-fix