Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(113)

Issue 3169042: Python #8525

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by merwok
Modified:
9 years, 11 months ago
Reviewers:
sasha
Base URL:
http://svn.python.org/view/*checkout*/python/branches/py3k/
Visibility:
Public.

Patch Set 1 #

Total comments: 9
Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -0 lines) Patch
Lib/pydoc.py View 1 chunk +20 lines, -0 lines 8 comments Download
Lib/test/test_pydoc.py View 1 chunk +87 lines, -0 lines 1 comment Download

Messages

Total messages: 4
merwok
9 years, 11 months ago (2010-11-22 00:20:49 UTC) #1
merwok
http://codereview.appspot.com/3169042/diff/1/Lib/pydoc.py File Lib/pydoc.py (right): http://codereview.appspot.com/3169042/diff/1/Lib/pydoc.py#newcode1145 Lib/pydoc.py:1145: if not attrval is object: If find it more ...
9 years, 11 months ago (2010-11-22 00:25:37 UTC) #2
sasha
http://codereview.appspot.com/3169042/diff/1/Lib/pydoc.py File Lib/pydoc.py (right): http://codereview.appspot.com/3169042/diff/1/Lib/pydoc.py#newcode1144 Lib/pydoc.py:1144: for attr, attrval in __builtins__.items(): "attr" is not used ...
9 years, 11 months ago (2010-11-22 01:25:38 UTC) #3
merwok
9 years, 11 months ago (2010-11-22 01:46:06 UTC) #4
http://codereview.appspot.com/3169042/diff/1/Lib/pydoc.py
File Lib/pydoc.py (right):

http://codereview.appspot.com/3169042/diff/1/Lib/pydoc.py#newcode1144
Lib/pydoc.py:1144: for attr, attrval in __builtins__.items():
It is always correct to use builtins instead of the CPython implementation
detail.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b