Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6794)

Issue 316510043: ui/gtk3: Change modal dialog to focused dialog (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years ago by fujiwara
Modified:
7 years ago
Reviewers:
shawn.p.huang, Peng Wu, Peng
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

ui/gtk3: Change modal dialog to focused dialog There are several problems with the current emoji modal dialog. If keyboard is grabbed on the popup window, the focus out/in events cannot be detected so the dialog cannot be closed by the focus changes. If mouse operation is supported on the popup window, need a custom GtkHeaderBar with extended handle.vala but the behavior is unclear. [1] Also current popup window has several extensions for the keyboard grab. If the closed button is needed on the popup window since the focus events cannot be detected, I think there is no merit to use the popup window. Now IBusEmojier simply uses the focused window. [1] https://mail.gnome.org/archives/gtk-app-devel-list/2017-April/msg00017.html R=Shawn.P.Huang@gmail.com, alexepico@gmail.com Committed: c6cdf21c7364cbb1e848e44cab0bff270e432e82

Patch Set 1 #

Patch Set 2 : Updated with the latest master #

Patch Set 3 : Updated with the latest master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -231 lines) Patch
M ui/gtk3/emojier.vala View 21 chunks +98 lines, -145 lines 0 comments Download
M ui/gtk3/emojierapp.vala View 1 2 4 chunks +18 lines, -37 lines 0 comments Download
M ui/gtk3/ibusemojidialog.h View 3 chunks +26 lines, -28 lines 0 comments Download
M ui/gtk3/panel.vala View 9 chunks +52 lines, -21 lines 0 comments Download

Messages

Total messages: 6
fujiwara
7 years ago (2017-04-14 13:37:50 UTC) #1
fujiwara
CC'ing alexepico
7 years ago (2017-04-14 13:49:43 UTC) #2
fujiwara
Updated the patch to sync https://github.com/ibus/ibus/commit/290f786b82 .
7 years ago (2017-04-17 07:04:04 UTC) #3
Peng Wu
lgtm
7 years ago (2017-04-18 03:02:23 UTC) #4
Peng
On 2017/04/18 03:02:23, Peng Wu wrote: > lgtm lgtm
7 years ago (2017-04-18 18:10:50 UTC) #5
fujiwara
7 years ago (2017-04-19 03:16:55 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
c6cdf21c7364cbb1e848e44cab0bff270e432e82 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b