Issue 316220043: TBR: i#1273 use drmgr everywhere: update inc2add to use drmgr and drreg

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 316220043: TBR: i#1273 use drmgr everywhere: update inc2add to use drmgr and drreg

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 2 months ago by bruening

Modified:
7 years, 2 months ago

Reviewers:
zhaoqin

CC:
dynamorio-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- i#1273 use drmgr everywhere: update inc2add to use drmgr and drreg Updates the inc2add sample to use drmgr's app2app event and check the for_trace parameter. Changes the sample to always enable its transformation, so that we can actually test that part of the code. Also updates inc2add to use drreg for aflags liveness information. ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -70 lines)			Patch
	M	api/samples/CMakeLists.txt	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	api/samples/inc2add.c	View		6 chunks	+66 lines, -68 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bruening

7 years, 2 months ago (2017-01-30 05:59:39 UTC) #2

Committed as
https://github.com/DynamoRIO/dynamorio/commit/df5cd2a3f0cba083df8bffea72efe22...

Final commit log: 
---------------
i#1273 use drmgr everywhere: update inc2add to use drmgr and drreg

Updates the inc2add sample to use drmgr's app2app event and check the
for_trace parameter.  Changes the sample to always enable its
transformation, so that we can actually test that part of the code.

Also updates inc2add to use drreg for aflags liveness information.

Review-URL: https://codereview.appspot.com/316220043
---------------

Expand All Messages | Collapse All Messages