Issue 316210043: TBR: Allow 0 raw spill slots to be requested

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 316210043: TBR: Allow 0 raw spill slots to be requested

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 2 months ago by bruening

Modified:
7 years, 2 months ago

Reviewers:
zhaoqin

CC:
dynamorio-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- Allow 0 raw spill slots to be requested Updates dr_raw_tls_calloc() to support requests of 0 spill slots, solely to obtain the segment register. Updates helper routines to fail on 0 slots. This usage shows up with drreg with the inc2add sample which doesn't want to spill but wants to analyze liveness. ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -6 lines)			Patch
M	core/lib/instrument.c	View	3 chunks	+5 lines, -1 line	0 comments	Download
M	core/lib/instrument_api.h	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	core/unix/os.c	View	1 chunk	+1 line, -1 line	0 comments	Download
M	core/win32/os.c	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	ext/drreg/drreg.c	View	2 chunks	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bruening

7 years, 2 months ago (2017-01-30 05:35:16 UTC) #2

Committed as
https://github.com/DynamoRIO/dynamorio/commit/21a12fb400a6e878161784dfd4fa625...

Final commit log: 
---------------
Allow 0 raw spill slots to be requested

Updates dr_raw_tls_calloc() to support requests of 0 spill slots, solely to
obtain the segment register.  Updates helper routines to fail on 0 slots.
This usage shows up with drreg with the inc2add sample which doesn't want
to spill but wants to analyze liveness.

Review-URL: https://codereview.appspot.com/316210043
---------------

Expand All Messages | Collapse All Messages