Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(8826)

Issue 316170043: TBR: i#2147: fix drmemtrace reachability failure with -prof_pcs

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 3 months ago by bruening
Modified:
7 years, 3 months ago
Reviewers:
zhaoqin
CC:
dynamorio-devs_googlegroups.com
Visibility:
Public.

Description

Commit log for first patchset: --------------- i#2147: fix drmemtrace reachability failure with -prof_pcs For -prof_pcs drmemtrace's jecxz won't reach over an out-of-line clean call. We use a brute-force quick solution of checking for the option and using a jecxz;jmp;jmp sequence when it's on. Fixes #2147 ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
M clients/drcachesim/tracer/tracer.cpp View 3 chunks +21 lines, -3 lines 0 comments Download

Messages

Total messages: 2
bruening
7 years, 3 months ago (2017-01-26 03:48:32 UTC) #1
bruening
7 years, 3 months ago (2017-01-26 03:48:33 UTC) #2
Committed as
https://github.com/DynamoRIO/dynamorio/commit/16f386358c2c1000005590d2fbc1ba5...

Final commit log: 
---------------
i#2147: fix drmemtrace reachability failure with -prof_pcs

For -prof_pcs drmemtrace's jecxz won't reach over an out-of-line clean
call.  We use a brute-force quick solution of checking for the option and
using a jecxz;jmp;jmp sequence when it's on.

Fixes #2147

Review-URL: https://codereview.appspot.com/316170043
---------------
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b