Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5109)

Issue 316050043: TBR: i#2119: for static DR, on a fault, also invoke the app handler

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 4 months ago by bruening
Modified:
7 years, 4 months ago
Reviewers:
zhaoqin
CC:
dynamorio-devs_googlegroups.com
Visibility:
Public.

Description

Commit log for first patchset: --------------- i#2119: for static DR, on a fault, also invoke the app handler For static DR, invokes the app's fault handler, natively, on a DR fault. This takes advantage of app error reporting facilities. This is under a new on-by-default static-DR-only option -invoke_app_on_crash. If a fatal coredump is requested, the app's handler is tried first, and only if that returns is a fatal coredump from the kernel attempted. Adds a test api.static_crash. Augments the api.static_signal test to also test SIGSEGV app handling. Fixes #2119 ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -17 lines) Patch
M core/optionsx.h View 1 chunk +7 lines, -0 lines 0 comments Download
M core/unix/signal.c View 6 chunks +43 lines, -6 lines 0 comments Download
M core/win32/events.mc View 1 chunk +8 lines, -0 lines 0 comments Download
M suite/tests/CMakeLists.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A + suite/tests/api/static_crash.c View 4 chunks +30 lines, -10 lines 0 comments Download
A suite/tests/api/static_crash.templatex View 1 chunk +5 lines, -0 lines 0 comments Download
M suite/tests/api/static_signal.c View 5 chunks +15 lines, -0 lines 0 comments Download
M suite/tests/api/static_signal.expect View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 2
bruening
7 years, 4 months ago (2016-12-22 23:41:49 UTC) #1
bruening
7 years, 4 months ago (2016-12-22 23:41:52 UTC) #2
Committed as
https://github.com/DynamoRIO/dynamorio/commit/9d8e8abc71e8a984a966f1b82f442e5...

Final commit log: 
---------------
i#2119: for static DR, on a fault, also invoke the app handler

For static DR, invokes the app's fault handler, natively, on a DR fault.
This takes advantage of app error reporting facilities.
This is under a new on-by-default static-DR-only option
-invoke_app_on_crash.

If a fatal coredump is requested, the app's handler is tried first, and
only if that returns is a fatal coredump from the kernel attempted.

Adds a test api.static_crash.

Augments the api.static_signal test to also test SIGSEGV app handling.

Fixes #2119

Review-URL: https://codereview.appspot.com/316050043
---------------
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b