Issue 315990043: TBR: i#2041: remove flaky test from client.file_io

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 315990043: TBR: i#2041: remove flaky test from client.file_io

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 4 months ago by bruening

Modified:
7 years, 4 months ago

Reviewers:
zhaoqin

CC:
dynamorio-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- i#2041: remove flaky test from client.file_io Removes the comparisons of dr_get_time() fields with localtime() on UNIX and GetSystemTime() on Windows as it's just too complex to easily compare in a non-flaky manner. Fixes #2041 ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -26 lines)			Patch
	M	suite/tests/client-interface/file_io.dll.c	View		1 chunk	+5 lines, -26 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bruening

7 years, 4 months ago (2016-12-12 20:18:11 UTC) #2

Committed as
https://github.com/DynamoRIO/dynamorio/commit/8a4902d433a23574223b0aaa268aebe...

Final commit log: 
---------------
i#2041: remove flaky test from client.file_io

Removes the comparisons of dr_get_time() fields with localtime() on UNIX and
GetSystemTime() on Windows as it's just too complex to easily compare
in a non-flaky manner.

Fixes #2041

Review-URL: https://codereview.appspot.com/315990043
---------------

Expand All Messages | Collapse All Messages