Issue 315970043: TBR: i#1984 sigaction: return proper prior sigaction

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 315970043: TBR: i#1984 sigaction: return proper prior sigaction

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 4 months ago by bruening

Modified:
7 years, 4 months ago

Reviewers:
zhaoqin

CC:
dynamorio-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- i#1984 sigaction: return proper prior sigaction Fixes sigaction handling to return the actual prior application sigaction rather than the newly-being-set value, for both RT and non-RT flavors. Adds simple tests to linux.sigaction for both RT and non-RT sigaction. More extensive tests will come when linux.sigaction_nosignals is enabled in the future. ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+169 lines, -55 lines)			Patch
M	core/unix/signal.c	View	7 chunks	+59 lines, -46 lines	0 comments	Download
M	core/unix/signal_private.h	View	2 chunks	+7 lines, -1 line	0 comments	Download
M	suite/tests/linux/sigaction.c	View	3 chunks	+103 lines, -8 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bruening

7 years, 4 months ago (2016-12-11 05:16:49 UTC) #2

Committed as
https://github.com/DynamoRIO/dynamorio/commit/53bc931a5f550d9804692bca9278917...

Final commit log: 
---------------
i#1984 sigaction: return proper prior sigaction

Fixes sigaction handling to return the actual prior application sigaction
rather than the newly-being-set value, for both RT and non-RT flavors.

Adds simple tests to linux.sigaction for both RT and non-RT sigaction.
More extensive tests will come when linux.sigaction_nosignals is enabled in
the future.

Review-URL: https://codereview.appspot.com/315970043
---------------

Expand All Messages | Collapse All Messages