Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(136)

Issue 315570043: Let analysis brackets support text (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months, 2 weeks ago by thomasmorley651
Modified:
5 months ago
Reviewers:
lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Let analysis brackets support text Ability to add labels to brackets is essential for musical analysis. This patch introduces a new grob, "HorizontalBracketText," a spanner created along with "HorizontalBracket" by Horizontal_bracket_engraver. Repeated text of broken brackets is parenthesized.

Patch Set 1 #

Total comments: 1

Patch Set 2 : reflect review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -12 lines) Patch
M Documentation/changes.tely View 1 chunk +18 lines, -0 lines 0 comments Download
M Documentation/notation/editorial.itely View 1 chunk +10 lines, -3 lines 0 comments Download
A Documentation/snippets/new/analysis-brackets-with-labels.ly View 1 chunk +38 lines, -0 lines 0 comments Download
A input/regression/horizontal-bracket-broken-texted.ly View 1 chunk +25 lines, -0 lines 0 comments Download
A input/regression/horizontal-bracket-texted.ly View 1 1 chunk +36 lines, -0 lines 0 comments Download
M lily/horizontal-bracket.cc View 2 chunks +1 line, -5 lines 0 comments Download
M lily/horizontal-bracket-engraver.cc View 5 chunks +27 lines, -4 lines 0 comments Download
M scm/define-grob-interfaces.scm View 1 chunk +5 lines, -0 lines 0 comments Download
M scm/define-grob-properties.scm View 1 chunk +1 line, -0 lines 0 comments Download
M scm/define-grobs.scm View 1 chunk +18 lines, -0 lines 0 comments Download
M scm/output-lib.scm View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 2
lemzwerg
LGTM https://codereview.appspot.com/315570043/diff/1/input/regression/horizontal-bracket-texted.ly File input/regression/horizontal-bracket-texted.ly (right): https://codereview.appspot.com/315570043/diff/1/input/regression/horizontal-bracket-texted.ly#newcode5 input/regression/horizontal-bracket-texted.ly:5: @code{text} property of the @code{HorizontalBracketText} object. It should ...
5 months, 2 weeks ago (2017-02-08 07:25:25 UTC) #1
thomasmorley651
5 months ago (2017-02-15 21:34:26 UTC) #2
reflect review
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted