Issue 315570043: Let analysis brackets support text

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 315570043: Let analysis brackets support text (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 2 months ago by thomasmorley651

Modified:
7 years, 2 months ago

Reviewers:
lemzwerg

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Let analysis brackets support text Ability to add labels to brackets is essential for musical analysis. This patch introduces a new grob, "HorizontalBracketText," a spanner created along with "HorizontalBracket" by Horizontal_bracket_engraver. Repeated text of broken brackets is parenthesized.

Patch Set 1 #

Total comments: 1

Patch Set 2 : reflect review #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+206 lines, -12 lines)			Patch
M	Documentation/changes.tely	View		1 chunk	+18 lines, -0 lines	0 comments	Download
M	Documentation/notation/editorial.itely	View		1 chunk	+10 lines, -3 lines	0 comments	Download
A	Documentation/snippets/new/analysis-brackets-with-labels.ly	View		1 chunk	+38 lines, -0 lines	0 comments	Download
A	input/regression/horizontal-bracket-broken-texted.ly	View		1 chunk	+25 lines, -0 lines	0 comments	Download
A	input/regression/horizontal-bracket-texted.ly	View	1	1 chunk	+36 lines, -0 lines	0 comments	Download
M	lily/horizontal-bracket.cc	View		2 chunks	+1 line, -5 lines	0 comments	Download
M	lily/horizontal-bracket-engraver.cc	View		5 chunks	+27 lines, -4 lines	0 comments	Download
M	scm/define-grob-interfaces.scm	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	scm/define-grob-properties.scm	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	scm/define-grobs.scm	View		1 chunk	+18 lines, -0 lines	0 comments	Download
M	scm/output-lib.scm	View		1 chunk	+27 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

lemzwerg

LGTM https://codereview.appspot.com/315570043/diff/1/input/regression/horizontal-bracket-texted.ly File input/regression/horizontal-bracket-texted.ly (right): https://codereview.appspot.com/315570043/diff/1/input/regression/horizontal-bracket-texted.ly#newcode5 input/regression/horizontal-bracket-texted.ly:5: @code{text} property of the @code{HorizontalBracketText} object. It should ...

7 years, 2 months ago (2017-02-08 07:25:25 UTC) #1

reflect review

Expand All Messages | Collapse All Messages