Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3839)

Issue 315480043: TBR: i#511 drreg: keep aflags in eax where possible

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 2 months ago by bruening
Modified:
7 years, 2 months ago
Reviewers:
zhaoqin
CC:
dynamorio-devs_googlegroups.com
Visibility:
Public.

Description

Commit log for first patchset: --------------- i#511 drreg: keep aflags in eax where possible Improves drreg's aflags preservation on x86 by keeping it in eax initially, instead of blindly spilling to TLS. Without this optimization, the samples doing their own increment insertion produced much better code than using drx_insert_counter_increment() with drreg. ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -38 lines) Patch
M ext/drreg/drreg.c View 12 chunks +141 lines, -38 lines 0 comments Download

Messages

Total messages: 2
bruening
7 years, 2 months ago (2017-01-30 05:43:21 UTC) #1
bruening
7 years, 2 months ago (2017-01-30 05:43:23 UTC) #2
Committed as
https://github.com/DynamoRIO/dynamorio/commit/00d39c73c9d23b5ee76889c4e9157f4...

Final commit log: 
---------------
i#511 drreg: keep aflags in eax where possible

Improves drreg's aflags preservation on x86 by keeping it in eax initially,
instead of blindly spilling to TLS.  Without this optimization, the samples
doing their own increment insertion produced much better code than using
drx_insert_counter_increment() with drreg.

Review-URL: https://codereview.appspot.com/315480043
---------------
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b