Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7602)

Issue 315460043: TBR: i#2121 date conversion: fix Windows build breakage

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 3 months ago by bruening
Modified:
7 years, 3 months ago
Reviewers:
edmund.grimley.evans, Edmund.Grimley.Evans
CC:
dynamorio-devs_googlegroups.com
Visibility:
Public.

Description

Commit log for first patchset: --------------- i#2121 date conversion: fix Windows build breakage Fixes Windows build breakage from f708ccc. ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M core/utils.c View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8
bruening
7 years, 3 months ago (2017-01-23 16:35:36 UTC) #1
bruening
Committed as https://github.com/DynamoRIO/dynamorio/commit/408e012beb50dac567612ef117f6149fec1ba65c Final commit log: --------------- i#2121 date conversion: fix Windows build breakage Fixes ...
7 years, 3 months ago (2017-01-23 16:35:38 UTC) #2
Edmund.Grimley.Evans
LGTM, except that one of those casts is required to prevent overflow. It's kind of ...
7 years, 3 months ago (2017-01-23 17:01:28 UTC) #3
bruening
Please hold off until AppVeyor is set up -- then you can use a pull ...
7 years, 3 months ago (2017-01-23 17:06:48 UTC) #4
Edmund.Grimley.Evans
On 2017/01/23 17:06:48, bruening wrote: > Please hold off until AppVeyor is set up -- ...
7 years, 3 months ago (2017-01-23 17:10:28 UTC) #5
bruening
Initial setup is complete. Preliminary mods to wiki complete. Precise workflow still in flux though. ...
7 years, 3 months ago (2017-01-23 20:26:32 UTC) #6
bruening
In case it wasn't clear, go ahead w/ the pull request. On Mon, Jan 23, ...
7 years, 3 months ago (2017-01-23 21:21:22 UTC) #7
Edmund.Grimley.Evans
7 years, 3 months ago (2017-01-24 09:27:13 UTC) #8
On 2017/01/23 21:21:22, bruening wrote:
> In case it wasn't clear, go ahead w/ the pull request.

Done, I think. What next?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b