Issue 315390043: TBR: Adds comments about dumping as text to {mem,ins}trace_simple.c

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 315390043: TBR: Adds comments about dumping as text to {mem,ins}trace_simple.c

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 3 months ago by bruening

Modified:
7 years, 3 months ago

Reviewers:
zhaoqin

CC:
dynamorio-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- Adds comments about dumping as text to {mem,ins}trace_simple.c Previously we had comments in the {mem,ins}trace_x86.c samples about text versus binary and pointing at the corresponding _simple.c sample, but not the other way around. Those comments are added here. ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -4 lines)			Patch
	M	api/samples/instrace_simple.c	View		2 chunks	+3 lines, -1 line	0 comments	Download
	M	api/samples/memtrace_simple.c	View		3 chunks	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bruening

7 years, 3 months ago (2017-01-13 03:04:56 UTC) #2

Committed as
https://github.com/DynamoRIO/dynamorio/commit/fa08970bebca016a58c93775096583e...

Final commit log: 
---------------
Adds comments about dumping as text to {mem,ins}trace_simple.c

Previously we had comments in the {mem,ins}trace_x86.c samples about text
versus binary and pointing at the corresponding _simple.c sample, but not
the other way around.  Those comments are added here.

Review-URL: https://codereview.appspot.com/315390043
---------------

Expand All Messages | Collapse All Messages