Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5720)

Issue 315380043: i#1902 VS2015 link: fixes DR and drmf samples fail to link with VS2015

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 3 months ago by firodj
Modified:
7 years, 3 months ago
Reviewers:
bruening
CC:
dynamorio-devs_googlegroups.com
Visibility:
Public.

Description

Commit log for first patchset: --------------- i#1902 VS2015 link: fixes DR and drmf samples fail to link with VS2015 According to https://blogs.msdn.microsoft.com/vcblog/2015/03/03/introducing-the-universal-crt/ VS 2015 add two more lib to link besides `libcmt` which are `libvcruntime` and `libucrt`. Fixes #1902 ---------------

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M make/DynamoRIOConfig.cmake.in View 2 chunks +8 lines, -0 lines 3 comments Download

Messages

Total messages: 5
firodj
7 years, 3 months ago (2017-01-11 15:15:20 UTC) #1
bruening
2 minor comments that should be easy to fix, else LGTM BTW if you're willing ...
7 years, 3 months ago (2017-01-11 18:42:05 UTC) #2
bruening
I'll go ahead and commit this with you as the source
7 years, 3 months ago (2017-01-19 17:32:29 UTC) #3
bruening
https://codereview.appspot.com/315380043/diff/1/make/DynamoRIOConfig.cmake.in File make/DynamoRIOConfig.cmake.in (right): https://codereview.appspot.com/315380043/diff/1/make/DynamoRIOConfig.cmake.in#newcode783 make/DynamoRIOConfig.cmake.in:783: if (MSVC_VERSION GREATER_EQUAL 1900) I get: CMake Error at ...
7 years, 3 months ago (2017-01-19 17:58:43 UTC) #4
bruening
7 years, 3 months ago (2017-01-19 18:33:47 UTC) #5
Committed as 94aeb0eb8115740c368f70659bb089ad5ece34b2
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b