Issue 315260043: TBR: i#2117: disable -private_loader for UNIX static DR

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 315260043: TBR: i#2117: disable -private_loader for UNIX static DR

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 4 months ago by bruening

Modified:
7 years, 4 months ago

Reviewers:
zhaoqin

CC:
dynamorio-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- i#2117: disable -private_loader for UNIX static DR For static DR on UNIX we do not want to swap TLS, so we disable -private_loader by default. We leave it on for Windows where the alternate TLS is less significant and where at least partial isolation is still possible. Adds a comment about the current app TLS size assumptions being incorrect. Fixing it is complex though and is not attempted here. Fixes #2117 ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -2 lines)			Patch
M	core/options.c	View	1 chunk	+1 line, -1 line	0 comments	Download
M	core/optionsx.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	core/unix/loader_linux.c	View	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bruening

7 years, 4 months ago (2016-12-22 17:57:03 UTC) #2

Committed as
https://github.com/DynamoRIO/dynamorio/commit/f687c8ee55133f8a0744e3f49d64c8e...

Final commit log: 
---------------
i#2117: disable -private_loader for UNIX static DR

For static DR on UNIX we do not want to swap TLS, so we disable
-private_loader by default.  We leave it on for Windows where the alternate
TLS is less significant and where at least partial isolation is still
possible.

Adds a comment about the current app TLS size assumptions being incorrect.
Fixing it is complex though and is not attempted here.

Fixes #2117

Review-URL: https://codereview.appspot.com/315260043
---------------

Expand All Messages | Collapse All Messages