Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(9332)

Issue 315110043: TBR: i#2069: remove over-zealous assert on app munmap overlap

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 4 months ago by bruening
Modified:
7 years, 4 months ago
Reviewers:
zhaoqin
CC:
dynamorio-devs_googlegroups.com
Visibility:
Public.

Description

Commit log for first patchset: --------------- i#2069: remove over-zealous assert on app munmap overlap Removes an assert on an app munmap overlapping allocated space as this happensin real apps and furthermore DR should not assert on failing or nop app syscalls. Fixes #2069 ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M core/unix/memcache.c View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2
bruening
7 years, 4 months ago (2016-12-01 22:03:43 UTC) #1
bruening
7 years, 4 months ago (2016-12-01 22:03:45 UTC) #2
Committed as
https://github.com/DynamoRIO/dynamorio/commit/3e12b156b30f47cf2ca86599b0a55bb...

Final commit log: 
---------------
i#2069: remove over-zealous assert on app munmap overlap

Removes an assert on an app munmap overlapping allocated space as this
happensin real apps and furthermore DR should not assert on failing or nop
app syscalls.

Fixes #2069

Review-URL: https://codereview.appspot.com/315110043
---------------
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b