Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1184)

Issue 3151042: Pydoc enhanced browsing patch

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 2 months ago by ron3200
Modified:
3 years, 1 month ago
Reviewers:
Base URL:
http://svn.python.org/projects/python/branches/py3k/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : minor fix's #

Total comments: 23

Patch Set 3 : more fix's and removed urllib parse and tests. #

Patch Set 4 : issue2001_e.diff #

Patch Set 5 : issue2001_f with tests #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+634 lines, -35 lines) Patch
M Doc/library/pydoc.rst View 1 2 3 4 2 chunks +13 lines, -4 lines 0 comments Download
M Doc/whatsnew/3.2.rst View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M Lib/pydoc.py View 1 2 3 4 12 chunks +525 lines, -30 lines 2 comments Download
A Lib/pydoc_data/_pydoc.css View 1 chunk +6 lines, -0 lines 0 comments Download
M Lib/test/test_pydoc.py View 3 chunks +71 lines, -1 line 0 comments Download
M Misc/ACKS View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M Misc/NEWS View 1 2 3 4 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 7
ron3200
http://codereview.appspot.com/3151042/diff/2001/Doc/library/pydoc.rst File Doc/library/pydoc.rst (right): http://codereview.appspot.com/3151042/diff/2001/Doc/library/pydoc.rst#newcode54 Doc/library/pydoc.rst:54: ``-p 1234`` will start a HTTP server on port ...
8 years, 2 months ago (2010-11-18 23:02:57 UTC) #1
ron3200
http://codereview.appspot.com/3151042/diff/2001/Doc/library/pydoc.rst File Doc/library/pydoc.rst (right): http://codereview.appspot.com/3151042/diff/2001/Doc/library/pydoc.rst#newcode54 Doc/library/pydoc.rst:54: ``-p 1234`` will start a HTTP server on port ...
8 years, 2 months ago (2010-11-19 00:23:48 UTC) #2
ron3200
http://codereview.appspot.com/3151042/diff/2001/Lib/pydoc.py File Lib/pydoc.py (right): http://codereview.appspot.com/3151042/diff/2001/Lib/pydoc.py#newcode2380 Lib/pydoc.py:2380: content_type = 'text/html' On 2010/11/19 00:23:48, ron3200 wrote: > ...
8 years, 2 months ago (2010-11-19 00:37:02 UTC) #3
ron3200
http://codereview.appspot.com/3151042/diff/2001/Lib/pydoc.py File Lib/pydoc.py (right): http://codereview.appspot.com/3151042/diff/2001/Lib/pydoc.py#newcode2343 Lib/pydoc.py:2343: #True On 2010/11/18 23:02:57, ron3200 wrote: > These lines ...
8 years, 2 months ago (2010-11-19 17:30:43 UTC) #4
ron3200
http://codereview.appspot.com/3151042/diff/2001/Lib/pydoc.py File Lib/pydoc.py (right): http://codereview.appspot.com/3151042/diff/2001/Lib/pydoc.py#newcode2538 Lib/pydoc.py:2538: f.close() Use with statement here. http://codereview.appspot.com/3151042/diff/2001/Lib/pydoc.py#newcode2650 Lib/pydoc.py:2650: fp = ...
8 years, 2 months ago (2010-11-19 21:10:27 UTC) #5
ron3200
http://codereview.appspot.com/3151042/diff/2001/Lib/pydoc.py File Lib/pydoc.py (right): http://codereview.appspot.com/3151042/diff/2001/Lib/pydoc.py#newcode2538 Lib/pydoc.py:2538: f.close() On 2010/11/19 21:10:27, ron3200 wrote: > Use with ...
8 years, 2 months ago (2010-11-19 21:11:55 UTC) #6
ron3200
8 years, 2 months ago (2010-11-21 06:48:24 UTC) #7
Almost done, I hope. ;-)

http://codereview.appspot.com/3151042/diff/18001/Lib/pydoc.py
File Lib/pydoc.py (right):

http://codereview.appspot.com/3151042/diff/18001/Lib/pydoc.py#newcode438
Lib/pydoc.py:438: </body></html>''' % (title, contents, css_path)
remove css_path left over from previous edit.

http://codereview.appspot.com/3151042/diff/18001/Lib/pydoc.py#newcode2335
Lib/pydoc.py:2335: >>> serverthread = pydoc._startserver(my_url_handler, port)
pydoc._startserver(  ->  pydoc._start_server(
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b