Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(81)

Issue 3148041: Add ability to specify arguments to default actions through environment variable

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 5 months ago by dmac
Modified:
13 years, 5 months ago
Reviewers:
Mark Mentovai, dmaclach, thomasvl
Base URL:
http://gyp.googlecode.com/svn/trunk/
Visibility:
Public.

Description

I was looking for the ability to do: GYP_RUN_ARGS="--gtest_filter=MultiProcessLockTest.*" xcodebuild -target "Run unit_tests" so that I wouldn't always be running all the tests. Thought this may be generally a useful feature.

Patch Set 1 #

Patch Set 2 : missing some files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M pylib/gyp/generator/msvs.py View 1 chunk +1 line, -1 line 0 comments Download
M pylib/gyp/generator/scons.py View 1 chunk +1 line, -1 line 0 comments Download
M pylib/gyp/generator/xcode.py View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5
dmac
Does this interest you at all?
13 years, 5 months ago (2010-11-16 21:06:04 UTC) #1
Mark Mentovai
Yes, this is probably of enough general interest to take. The one thing that concerns ...
13 years, 5 months ago (2010-11-16 21:37:08 UTC) #2
Mark Mentovai
http://googletest.googlecode.com/svn/trunk/test/gtest_filter_unittest.py says you can use the GTEST_FILTER environment variable. Does that work?
13 years, 5 months ago (2010-11-16 21:38:25 UTC) #3
dmaclach_google.com
Probably will be just fine. Not as general as what I was planning, but certainly ...
13 years, 5 months ago (2010-11-16 21:46:29 UTC) #4
Mark Mentovai
13 years, 5 months ago (2010-11-16 21:47:25 UTC) #5
I’m still open to what you were proposing if you’ve got a use case
that isn’t covered. But having a specific environment variable for the
task you’re interested in certainly gets us past the “how do you do
more than one argument?” question.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b