Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(902)

Issue 314480043: DCTM: Changes to use chronicle id instead of object id in the DocId urls (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 months, 1 week ago by Srinivas
Modified:
7 months ago
Reviewers:
JohnL
CC:
connector-cr_google.com
Visibility:
Public.

Description

Changes to use chronicle id instead of object id in the DocId urls

Patch Set 1 #

Total comments: 18

Patch Set 2 : Changes as per review. #

Total comments: 7

Patch Set 3 : Changes as per review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -66 lines) Patch
M src/com/google/enterprise/adaptor/documentum/DocumentumAdaptor.java View 1 11 chunks +29 lines, -31 lines 0 comments Download
M test/com/google/enterprise/adaptor/documentum/DocumentumAdaptorTest.java View 1 2 18 chunks +108 lines, -35 lines 0 comments Download

Messages

Total messages: 8
Srinivas
Please review the changes.
7 months, 1 week ago (2017-02-14 03:11:57 UTC) #1
JohnL
Two real issues, then mostly readability issues and my Freudian id vs ID pet peeve. ...
7 months, 1 week ago (2017-02-15 01:36:08 UTC) #2
Srinivas
Please review the changes. https://codereview.appspot.com/314480043/diff/1/src/com/google/enterprise/adaptor/documentum/DocumentumAdaptor.java File src/com/google/enterprise/adaptor/documentum/DocumentumAdaptor.java (right): https://codereview.appspot.com/314480043/diff/1/src/com/google/enterprise/adaptor/documentum/DocumentumAdaptor.java#newcode1275 src/com/google/enterprise/adaptor/documentum/DocumentumAdaptor.java:1275: * @param objectId the ID ...
7 months, 1 week ago (2017-02-17 00:59:23 UTC) #3
Srinivas
Please review the changes. https://codereview.appspot.com/314480043/diff/1/test/com/google/enterprise/adaptor/documentum/DocumentumAdaptorTest.java File test/com/google/enterprise/adaptor/documentum/DocumentumAdaptorTest.java (right): https://codereview.appspot.com/314480043/diff/1/test/com/google/enterprise/adaptor/documentum/DocumentumAdaptorTest.java#newcode1085 test/com/google/enterprise/adaptor/documentum/DocumentumAdaptorTest.java:1085: String id = query.substring(query.toLowerCase(). On ...
7 months, 1 week ago (2017-02-17 00:59:24 UTC) #4
JohnL
A few nits in the tests. John L https://codereview.appspot.com/314480043/diff/20001/test/com/google/enterprise/adaptor/documentum/DocumentumAdaptorTest.java File test/com/google/enterprise/adaptor/documentum/DocumentumAdaptorTest.java (right): https://codereview.appspot.com/314480043/diff/20001/test/com/google/enterprise/adaptor/documentum/DocumentumAdaptorTest.java#newcode1085 test/com/google/enterprise/adaptor/documentum/DocumentumAdaptorTest.java:1085: if ...
7 months, 1 week ago (2017-02-17 01:54:19 UTC) #5
Srinivas
Please review the changes. https://codereview.appspot.com/314480043/diff/20001/test/com/google/enterprise/adaptor/documentum/DocumentumAdaptorTest.java File test/com/google/enterprise/adaptor/documentum/DocumentumAdaptorTest.java (right): https://codereview.appspot.com/314480043/diff/20001/test/com/google/enterprise/adaptor/documentum/DocumentumAdaptorTest.java#newcode1085 test/com/google/enterprise/adaptor/documentum/DocumentumAdaptorTest.java:1085: if (query.toLowerCase().lastIndexOf(idPrefix) == -1) { ...
7 months, 1 week ago (2017-02-17 02:46:32 UTC) #6
JohnL
LGTM John L
7 months ago (2017-02-18 00:34:20 UTC) #7
Srinivas
7 months ago (2017-02-21 21:00:56 UTC) #8
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted