Issue 314450043: ui/gtk3: Refactor to set panel icon

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 314450043: ui/gtk3: Refactor to set panel icon (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 2 months ago by fujiwara

Modified:
7 years, 2 months ago

Reviewers:
shawn.p.huang, Peng

CC:
shawn.p.huang_gmail.com

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

ui/gtk3: Refactor to set panel icon Fix panel icon with icon_prop_key when use_global_engine is false. Also enhance to set engines when type Super+space quickly. R=Shawn.P.Huang@gmail.com Committed: b498ff571049bec2b3f3bf6f1747f0af18ff4764

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+114 lines, -35 lines)			Patch
	M	ui/gtk3/panel.vala	View		6 chunks	+78 lines, -29 lines	0 comments	Download
	M	ui/gtk3/switcher.vala	View		5 chunks	+36 lines, -6 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

fujiwara

7 years, 2 months ago (2017-02-13 03:19:55 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b498ff571049bec2b3f3bf6f1747f0af18ff4764 (presubmit successful).

Expand All Messages | Collapse All Messages