Issue 314380043: TBR: i#2131: add droption usage to a sample client

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 314380043: TBR: i#2131: add droption usage to a sample client

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 2 months ago by bruening

Modified:
7 years, 2 months ago

Reviewers:
zhaoqin

CC:
dynamorio-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- i#2131: add droption usage to a sample client Converts inscount.c to inscount.cpp and adds droption usage rather than raw parsing of its runtime option. Fixes an issue uncovered by this change: an external client hits an error when invoking use_DynamoRIO_extension(client droption). Fixes #2131 ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -215 lines)			Patch
M	api/samples/CMakeLists.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
D	api/samples/inscount.c	View	1 chunk	+0 lines, -197 lines	0 comments	Download
A +	api/samples/inscount.cpp	View	6 chunks	+15 lines, -16 lines	0 comments	Download
M	make/DynamoRIOConfig.cmake.in	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bruening

7 years, 2 months ago (2017-01-30 16:21:56 UTC) #2

Committed as
https://github.com/DynamoRIO/dynamorio/commit/74d1190ccf848c19a25db313ff53c10...

Final commit log: 
---------------
i#2131: add droption usage to a sample client

Converts inscount.c to inscount.cpp and adds droption usage rather than raw
parsing of its runtime option.

Fixes an issue uncovered by this change: an external client hits an error
when invoking use_DynamoRIO_extension(client droption).

Fixes #2131

Review-URL: https://codereview.appspot.com/314380043
---------------

Expand All Messages | Collapse All Messages