Issue 314180043: TBR: i#1986 WSL: use safe reads for get_segment_base() on WSL

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 314180043: TBR: i#1986 WSL: use safe reads for get_segment_base() on WSL

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 4 months ago by bruening

Modified:
7 years, 4 months ago

Reviewers:
zhaoqin

CC:
dynamorio-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- i#1986 WSL: use safe reads for get_segment_base() on WSL Adds safe_read_tls_self() and safe_read_tls_app_self() for reading the segment bases under the Windows Subsystem for Linux (WSL), where the arch_prctl queries are broken in the kernel. Relaxes the fatal error on WSL into a warning as small tests now seem to work, though with some curiosities. Further testing is still needed. ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+123 lines, -23 lines)			Patch
M	core/arch/asm_defines.asm	View	2 chunks	+8 lines, -2 lines	0 comments	Download
M	core/arch/x86/x86.asm	View	1 chunk	+27 lines, -3 lines	0 comments	Download
M	core/unix/loader_linux.c	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	core/unix/os.c	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	core/unix/os_asm_defines.asm	View	1 chunk	+13 lines, -5 lines	0 comments	Download
M	core/unix/os_private.h	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	core/unix/signal.c	View	1 chunk	+9 lines, -1 line	0 comments	Download
M	core/unix/tls.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	core/unix/tls_linux_x86.c	View	5 chunks	+44 lines, -10 lines	0 comments	Download
M	core/win32/events.mc	View	1 chunk	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bruening

7 years, 4 months ago (2016-12-11 00:48:54 UTC) #2

Committed as
https://github.com/DynamoRIO/dynamorio/commit/826aae0ed0e415add3ecae33388d231...

Final commit log: 
---------------
i#1986 WSL: use safe reads for get_segment_base() on WSL

Adds safe_read_tls_self() and safe_read_tls_app_self() for reading the
segment bases under the Windows Subsystem for Linux (WSL), where the
arch_prctl queries are broken in the kernel.

Relaxes the fatal error on WSL into a warning as small tests now seem to
work, though with some curiosities.  Further testing is still needed.

Review-URL: https://codereview.appspot.com/314180043
---------------

Expand All Messages | Collapse All Messages