Issue 314150043: Support .NET service URLs.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 314150043: Support .NET service URLs. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 4 months ago by Gennis

Modified:
7 years, 4 months ago

Reviewers:
JohnL

CC:
connector-cr_google.com

Visibility:
Public.

More Reviews

Description

Support .NET service URLs. When trying service URLs, default to the .NET style of "name.svc". If that fails, try the URL without the extension. Provide a config property to allow the connector admin to override the default. https://github.com/googlegsa/opentext/commit/e73f268367e730a1a7ee53b2b5df00a44b1ad8c5

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review issues. #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+132 lines, -60 lines)			Patch
M	adaptor-config.properties.sample	View	1	1 chunk	+11 lines, -1 line	0 comments	Download
M	src/com/google/enterprise/adaptor/opentext/OpentextAdaptor.java	View	1	9 chunks	+73 lines, -24 lines	0 comments	Download
M	test/com/google/enterprise/adaptor/opentext/OpentextAdaptorTest.java	View	1	9 chunks	+48 lines, -35 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

JohnL

For posterity. John L https://codereview.appspot.com/314150043/diff/1/adaptor-config.properties.sample File adaptor-config.properties.sample (right): https://codereview.appspot.com/314150043/diff/1/adaptor-config.properties.sample#newcode9 adaptor-config.properties.sample:9: # installations and one for ...

7 years, 4 months ago (2016-12-07 21:37:18 UTC) #2

LGTM

John L

Expand All Messages | Collapse All Messages